From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127905 invoked by alias); 18 Nov 2016 17:04:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127866 invoked by uid 89); 18 Nov 2016 17:04:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Nov 2016 17:04:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E1D6ADAC8; Fri, 18 Nov 2016 17:04:36 +0000 (UTC) Received: from [10.36.6.181] (vpn1-6-181.ams2.redhat.com [10.36.6.181]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAIH4Yxk029852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Nov 2016 12:04:35 -0500 Subject: Re: Require GNU make to build binutils-gdb To: Simon Marchi References: <144f4f68acf24fc1084b585700c65b63@polymtl.ca> <80053c28-1a47-8f80-04fb-7bdf76115077@redhat.com> <85e5ade0f75ee3ced79946ec9462b7f6@polymtl.ca> Cc: binutils@sourceware.org, gdb-patches@sourceware.org From: Nick Clifton Message-ID: <5fab6734-6b06-fc27-785f-cb3af2076d4e@redhat.com> Date: Fri, 18 Nov 2016 17:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <85e5ade0f75ee3ced79946ec9462b7f6@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00514.txt.bz2 Hi Simon, >> I think that this is a good idea, although maybe it would be >> helpful to take a two stage approach: for one release (of >> binutils) issue an error message if a non-GNU make is used, >> but allow a configure option to override this. (In the same >> way that obsolete targets are currently handled). Then for >> the release after that make GNU make a hard requirement. > That seems fair. Would you add that check in the top-level > Makefile or in the binutils/ Makefile? Well, the top-level Makefile is shared with gcc, so we would have to get approval there as well. Putting the check in the binutils/ Makefile would certainly be easier, and it should be sufficient (The only target that I could find that does not build the binutils sub-directory is the v810, which is not supported as a binutils target anyway). Cheers Nick