From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IsIBKEzt+2gr5gYAWB0awg (envelope-from ) for ; Fri, 24 Oct 2025 17:19:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d7PH8xlJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 931251E057; Fri, 24 Oct 2025 17:19:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 35CF21E057 for ; Fri, 24 Oct 2025 17:19:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE5723858039 for ; Fri, 24 Oct 2025 21:19:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE5723858039 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d7PH8xlJ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 92A753858D3C for ; Fri, 24 Oct 2025 21:18:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92A753858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92A753858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761340707; cv=none; b=UYxSNT2U9+OqWGIMOd/o75jvSkvRJ0i4TVvip+/IH37qTeqfzavY1tXrgDWdFEZynbvj7aL7xUR3Y/XDWmGDte/38BE/D3GJeIqFbfXDWmtiIm4NCpleCt6PqhYjpzK3azocKvlLNUkNFiVIYvXGzNC03r7Tl3HnE7MxX0k233s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761340707; c=relaxed/simple; bh=j9Fv3dxe1tW9mLleoaHpc+xn+bLVcFpX/w8OSEbWlcQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FP3m8efP8Ti7lAIU4/kCGQcEoTdvx0FNRBSSlvUudQocGb/E1dBXOTagrTyg+/Xe24MwQXFgZZFzEIntX8oDkdfn0D701d+FO9yiqmezWhF9YHcKIXzwF8saZ39HU5n7ohoSchQuHQpkNO/uwGhWHEGtdMaY1ZS5njfXf+Lz35M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 92A753858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761340707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=99zdod8Su71i4kTWatmnIWmBEN9ArvYV+9hlB/wrYkw=; b=d7PH8xlJr8PA0TadQEcnhw4I6zQyNVjtTv7bgW5JjTMnIylT+7fcv5NP9IpbZL7Q81YTo1 zMN0xc41FPDSO3GMa0sd+QlwwUSn4bYp2foPYTXMJb2dRek/oQBmsi/e8XlOrcP35vvzOo yHBd2i3a4pRy4+28kX6GO3jVTzY/cAc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-SY6YiR1oMJurYQGZGFJz1g-1; Fri, 24 Oct 2025 17:18:25 -0400 X-MC-Unique: SY6YiR1oMJurYQGZGFJz1g-1 X-Mimecast-MFC-AGG-ID: SY6YiR1oMJurYQGZGFJz1g_1761340704 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e4cb3e4deso10670675e9.1 for ; Fri, 24 Oct 2025 14:18:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761340703; x=1761945503; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=99zdod8Su71i4kTWatmnIWmBEN9ArvYV+9hlB/wrYkw=; b=fBxZ2a+C4Ad5+DqnDlSLQUHc61yI2/oaPHtWdyYwQ+FjcLWgtF2SCag3expjRle0X+ jJWL8Tom1glxi+7SaLFDagHxiKS7a1BtgAxJTDhf886nPUuIa8WE0uxck00EQUCzCBd9 VmpurNmN9R338DEjfRuHwCGwhl6jU4540Mn+vododLQ4AZqlz3aXIWAYTjyVn/KJrAKb G7qIV2phWOoX/0wDVPbqAbXzr9gzXc82F0vmE1AoDyu8TdJICxSGh+mBXJ6QYbvn8mEl IzF45J0p4BniDcPUkkIjWkqc+G2Nx++ImiHoJ9Pb1stuaGPkP59ZewNaHlVKn8fG8tgZ n3Pw== X-Gm-Message-State: AOJu0Yw0bksFEopAtjRc3qufwmtt+Zw8fKiVqpmn51TIMPF2xm5YfGR6 C5tjczxegxcSx40GP28TxTtGhOBNrcSvep55xMv96xeYoh+1I2ysV3fafdGWND6NuAqFN/j8UN6 qfgwd/cE8kRv4mWr7eDY0wsCoEjmYN8qAchgU5E+Vmhu/XHqCnQvroog7QvL1I+MrOPTPZFKxo1 53c4ViYG9WBBz/aS+jxZwGZqE1huSeLiATYXIbacu0gOv8kDQ= X-Gm-Gg: ASbGncvgxwJCZEzJDZ9QsT1EWWAaI0TBrAC/t2Q6cOhBiSqkjlcMvIp0DRriuwdoDsI 7GaWl2Jo5SEq82DgC/9BYIYYRU6f/xpWW4l7HYKhQFQ2ipIMu60uwqlzadqGXeC+z4rZ5ec2/Cs jLVuFcrVsCAck0zvj7/A8AF+pFelwFS/ca2Y+lJRzaZRLkRM2yobsARCwQQu3a4cKvQ1kNDRK9A aPOjl7qRTIHRvYDdDDCQ7tFNLEPvpb33T8YBEdSPK4MveT/Eov7hoACM7EoXyr41Uc/Y3Igfl2v wprkD7t0HLK2BJM3BcXstDU7Arx0XkAVfJmC5TxP/hAfNmtL04FPDSoXqYxULtPJrQiZWQ== X-Received: by 2002:a05:600c:a20e:b0:475:dadd:c474 with SMTP id 5b1f17b1804b1-475daddc749mr5244625e9.10.1761340703424; Fri, 24 Oct 2025 14:18:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6Et9fPRjA95Gin64J416//lJAWqZXSDQXaz0/TI1VlOH5i4KIEfi/4PYaTfSEmkcabEbYqg== X-Received: by 2002:a05:600c:a20e:b0:475:dadd:c474 with SMTP id 5b1f17b1804b1-475daddc749mr5244535e9.10.1761340702927; Fri, 24 Oct 2025 14:18:22 -0700 (PDT) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7badsm376639f8f.7.2025.10.24.14.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 14:18:22 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb/testsuite: fix git repository check in gdb.src/pre-commit.exp Date: Fri, 24 Oct 2025 22:18:19 +0100 Message-ID: <5fa8de4b2b28278dbc3bf4ae78709ee9e71c3aa0.1761340690.git.aburgess@redhat.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: K7CVmLEECtHBeMwIZlzvmjlikmt-jf3ERy132sRUfaI_1761340704 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In the recently added gdb.src/pre-commit.exp test, we check if the source directory is a git repository like this: if {![file isdirectory $repodir/.git]} { unsupported "Not in a git repository" return } I make extensive use of git worktrees for development. In a worktree .git is a file containing the location of the actual .git directory, it is not itself a directory. As such, the above check fails, claiming my source tree is not a git repository, when in fact, it is. Fix this by relaxing the check to 'file exists $repodir/.git', which will cover the directory and file case. --- gdb/testsuite/gdb.src/pre-commit.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.src/pre-commit.exp b/gdb/testsuite/gdb.src/pre-commit.exp index 5fb0dfed6d7..8745b31272e 100644 --- a/gdb/testsuite/gdb.src/pre-commit.exp +++ b/gdb/testsuite/gdb.src/pre-commit.exp @@ -17,7 +17,7 @@ set repodir $srcdir/../.. -if {![file isdirectory $repodir/.git]} { +if {![file exists $repodir/.git]} { unsupported "Not in a git repository" return } base-commit: 7d169f96d5f372c76ee560355af3dcac4355418f -- 2.47.1