From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40387 invoked by alias); 2 Jul 2018 16:53:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40374 invoked by uid 89); 2 Jul 2018 16:53:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=shut, wondering X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Jul 2018 16:53:12 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1B9241E08D; Mon, 2 Jul 2018 12:53:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530550390; bh=lcFSGpF7Uabq2DUtZxCcTQ0XTHgrdsZCfHJyr1N60LE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=eXwhKD6pcIvOdiLPaw6J5LgDOD7hC7UTjFgtaP9/sqpgTkj0M7RzgikGwfL9kam6B 3nPL4FARitlGifbHPaRoVKkkGZ/8akjuY1zo2Fj1TIfK5TsKrRPyh9VeZ/whEsrgOK Ot9V2egS50bodLgAdSZ4p+ZYIZYIWK0ehcCBg+TI= Subject: Re: [RFA] Make macOS build warning-free To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20180629165453.22888-1-tom@tromey.com> <87woudofal.fsf@tromey.com> From: Simon Marchi Message-ID: <5f9b4ce1-aa8d-30e3-98f9-f2c36c3869c6@simark.ca> Date: Mon, 02 Jul 2018 16:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87woudofal.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00018.txt.bz2 On 2018-07-02 10:58 AM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> About the gettext / non-literal warning, this is the patch I carry. I tried > Simon> to dig up why gettext doesn't define _INTL_MAY_RETURN_STRING_ARG for __APPLE_CC__ > Simon> but couldn't find it. My guess is that in a distant past, the Apple compiler > Simon> did not know about that attribute. You need another change to get rid of the warning > Simon> though. > > Thanks. > > I looked into this a little more. It seems like a huge effort, because, > first, upstream doesn't have this fix; and second, it seems like it > would have to be imported into gcc first. > > Fixing this upstream would probably require the same thing for other > functions, not just gettext. _INTL_MAY_RETURN_STRING_ARG thing is a gcc/binutils/gdb addition, on top of the v0.12.1 version of gettext. So we shouldn't have to deal with upstream gettext to fix this, since it's just the gcc/binutils/gdb addition that needs to be fixed. Getting the fixed accepted in gcc shouldn't take took long. > I think in the meantime I'll just --disable-nls. Perhaps you wouldn't > mind approving the symfile.c change in isolation. That bit looks good to me, at least to shut up the compiler. But I'm wondering if we still need that section_offsets structure, or if we could just replace it with std::vector/gdb:array_view. Simon