From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 3E67F3858D37 for ; Mon, 17 Aug 2020 08:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3E67F3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 33428AD7B; Mon, 17 Aug 2020 08:55:08 +0000 (UTC) Subject: Re: [PATCH] gdb: fix IA64 build failure of linux-nat To: Simon Marchi , Sergei Trofimovich , Kevin Buettner Cc: gdb-patches@sourceware.org, Sergei Trofimovich References: <20200519212710.1417100-1-slyfox@gentoo.org> <20200519150041.13df2b38@f31-4.lan> <20200816094521.061554bb@sf> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <5f684182-c8d5-744b-8486-18f89ffb30a3@suse.de> Date: Mon, 17 Aug 2020 10:54:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 08:54:45 -0000 On 8/16/20 11:51 PM, Simon Marchi wrote: > On 2020-08-16 4:45 a.m., Sergei Trofimovich via Gdb-patches wrote: >> On Tue, 19 May 2020 15:00:41 -0700 >> Kevin Buettner wrote: >> >>> On Tue, 19 May 2020 22:27:10 +0100 >>> Sergei Trofimovich via Gdb-patches wrote: >>> >>>> From: Sergei Trofimovich >>>> >>>> On IA64 built failed as: >>>> >>>> ``` >>>> ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope >>>> 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch)) >>>> | ^~~~~~~~~~~~~~~~ >>>> ``` >>>> >>>> The fix includes "gdbarch.h" header where symbol is declared. >>>> >>>> * gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used >>>> 'gdbarch_num_regs'. >>> >>> Okay, but please capitalize "include" in the ChangeLog entry prior >>> to pushing this change. >> >> Attached v2-* patch with capitalization changes. >> >> I don't have a 'gdb' write access yet (I think), but I do have GCC one. >> >> Should I request 'gdb' access as well as specified in >> https://sourceware.org/cgi-bin/pdw/ps_form.cgi ? > > Yes, that would be useful if you plan on contributing regularly. If it's just > a occasional patch, we can also push for you. As you wish. > >> >> Thank you for the review! > > A few more styling nits: > >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 9cc7e44cba7..8865e6949d6 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -4564,6 +4564,11 @@ >> >> * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open. >> >> +2020-05-19 Sergei Trofimovich >> + >> + * gdb/ia64-linux-nat.c: Include "gdbarch.h" to declare used >> + 'gdbarch_num_regs'. > > The file path should be relative to the ChangeLog location, so here just "ia64-linux-nat.c". > > Also, make sure that your new entry is at the top of the file (here, it's at line 4564), and > that you update the date to $TODAY when you push. For these reasons, most people don't include > the ChangeLog bits in the patch directly, but just include it in the commit log (as you did). > Of course, when pushing the patch, then you need to insert it in the ChangeLog file. > Hi, IA64 support was just obsoleted in bfd (commit 73d0dc162e "Obsolete ia64"). So, AFAIU, this should now be built with --enable-obsolete. What are the consequences for gdb IA64 patches ? Thanks, - Tom