From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Vnc2Hs7M4mIIEhwAWB0awg (envelope-from ) for ; Thu, 28 Jul 2022 13:52:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 640BF1E9ED; Thu, 28 Jul 2022 13:52:14 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xBtbkgOq; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1957C1E87E for ; Thu, 28 Jul 2022 13:52:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC8EC3856DEF for ; Thu, 28 Jul 2022 17:52:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC8EC3856DEF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659030733; bh=YmH93Dva5+p+j6+pfO/QFemTHBd51OsrlRQdNNl6Ntw=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xBtbkgOqQcdDTSktMiUlTTvv56+KLiy5Kd9Q1CPERk474eGTh9MQJnfC+hnobMvsc j4/eaEtY5YEvmIvY94cR4EK380tK8/QYJD+HTmAQembOLESiakF4soKGM1E3PykHai +kqjVWLjhx39pd5IpGradBTxtkXB6BUrza5fojZE= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5E2D83858D33 for ; Thu, 28 Jul 2022 17:51:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E2D83858D33 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 26SHpifC016252 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Jul 2022 13:51:49 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 26SHpifC016252 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7473C1E87E; Thu, 28 Jul 2022 13:51:44 -0400 (EDT) Message-ID: <5f002cdf-2afb-8e4b-814e-2db90452b224@polymtl.ca> Date: Thu, 28 Jul 2022 13:51:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 7/7] gdb/testsuite: add macros test for source files compiled in various ways Content-Language: fr To: Bruno Larsen , gdb-patches@sourceware.org References: <20220428033542.1636284-1-simon.marchi@polymtl.ca> <20220428033542.1636284-8-simon.marchi@polymtl.ca> <064ba095-12d1-8b27-47c4-50e34fcc3b99@redhat.com> In-Reply-To: <064ba095-12d1-8b27-47c4-50e34fcc3b99@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 28 Jul 2022 17:51:44 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> +# Based on `gcc -gdwarf-5 -g3 `, gcc 11 paired with gas from binutils 2.38. > > This comment wasn't really clear to me. Maybe something like "The > following calls are based on ..." or something to make clear that this > comment refers to a group of do_test calls below, would avoid possible > confusion. Done. I changed them to "The following tests are based on the output of...". Thanks, Simon