Re: [PATCH 2/4] Add amd64_windows_gregset_reg_offset

Simon Marchi
2020-08-20T22:08:59Z

On 2020-08-12 3:18 p.m., Jon Turney wrote:
> Register a gregset_reg_offset array for Cygwin x86_64 core dump parsing
> (this causes the generic i386_iterate_over_regset_sections() '.reg'
> section iterator to get installed by i386_gdbarch_init()).
>
> gdb/ChangeLog:
>
> 2020-07-01 Jon Turney <jon.turney@dronecode.org.uk>
>
> * amd64-windows-tdep.c(amd64_windows_gregset_reg_offset): Add.
> (amd64_windows_init_abi_common): ... and register.

That looks reasonable. I think i386_iterate_over_regset_sections should
be made static, if you want to make another (obvious I would say) patch.

Simon