From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ijiTCj6SCmgawQMAWB0awg (envelope-from ) for ; Thu, 24 Apr 2025 15:34:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=a8llDzyl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1B7901E0C3; Thu, 24 Apr 2025 15:34:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 944151E089 for ; Thu, 24 Apr 2025 15:34:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3B7E3858D38 for ; Thu, 24 Apr 2025 19:34:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3B7E3858D38 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=a8llDzyl Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 921CA3858D39 for ; Thu, 24 Apr 2025 19:33:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 921CA3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 921CA3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745523227; cv=none; b=bgw7C7n2AN4Hh0h/jL2PWbHzO1LKCCdG8Gx22KfDkQlxd2qcK48MJamJxQdORvPuHrpW9dVY0oIt+zKGmyAOMiuEr0TNy4YCxX2G8BVqiUz7qrIe305Jn5XGTod+cywKNhojJVVwPjX912EVhS7h0oZZRypDWnzaK2CM77xXBHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745523227; c=relaxed/simple; bh=Bp11Q6x5UV2+a+u/j8veTaWPy49j+PjpD/47wwTfbPg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ei7+hdp/pX3zKa7SKt+6jYaC52s9OnHOZqoqUWu4yOVeNznBnwxUatTuvFxgPdZRGLQ2BhX15NWXDnCF07kZZyH+A0IkLMYP4XQoDDjGpfkYaPSFZWgJM0FxH7f8gwBjzED7CoalCc2rkOTw8yAR146+gc2SJ1pLQC42s+gmO38= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 921CA3858D39 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 53OJXeqO142493 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 24 Apr 2025 15:33:47 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 53OJXeqO142493 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1745523227; bh=eS/4zLX4n5uMLfSSnjptYtqI2UvdwtQuikMqpEGFIZs=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=a8llDzylRu74Do+Z1fR+bhx4GMxiWI+0UYTHs5NTMfqlI7jCYKNc3Fi60WDujlRNv rRoxGGN5lf5i2GAYV2AcjRhQmiT0/SOnSWjICvmGl7j4G7XwZAkRG8fBgt14woqLBO QJpUuXJQEPULONWi0cyvvFYMsZ63h4JXPefdhYr8= Received: by simark.ca (Postfix, from userid 112) id 8EC861E0C3; Thu, 24 Apr 2025 15:33:40 -0400 (EDT) Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CED281E089; Thu, 24 Apr 2025 15:33:39 -0400 (EDT) Message-ID: <5eec1219-a2c6-4a35-8238-e682a235f0a1@polymtl.ca> Date: Thu, 24 Apr 2025 15:33:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: fix some flake8 F824 warnings To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250424184837.2257885-1-simon.marchi@polymtl.ca> <87v7qt4ave.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87v7qt4ave.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 Apr 2025 19:33:42 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-04-24 15:28, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> flake8 7.2.0 appears to have this new warning: > > Simon> F824: global name / nonlocal name is unused: name is never assigned in scope > > Simon> It points out a few places in our code base where "global" is not > Simon> necessary, fix them. > > I'm mildly meh about this since I find "global" easier to follow, but at > the same time I'm sure we use this style in some spots already anyway. Yeah, since Python doesn't require it, it means we'll have some spots that use it and some that don't. To make it clear a variable is global, I would suggest adopting a naming standard that makes it obvious. Global variables are often prefixed with `_`, which is a good indication already. Simon