From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yqc3FVk/a2LJOAMAWB0awg (envelope-from ) for ; Thu, 28 Apr 2022 21:28:57 -0400 Received: by simark.ca (Postfix, from userid 112) id 4978A1E058; Thu, 28 Apr 2022 21:28:57 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=FNB8mw6F; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BBCF11E01D for ; Thu, 28 Apr 2022 21:28:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E7763857829 for ; Fri, 29 Apr 2022 01:28:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E7763857829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651195736; bh=2iDcaHeMWB6gJhb//pqhemJQrYNYbKw9D5Gx0ioQ6XY=; h=Subject:To:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=FNB8mw6FV0tab0JESAAX9Xq4FJgbWi940GRj36/6HQuCCaPlPpyCxMQ0yDG/b4gL2 h0hKmtihscWshL6MKAhDQn+pCKE7FCmBO/XGLuSMX3w5CCDozyT8h61aGpQj9/xlPy 8BGA39+peeKrqvfNy3FLZIqf0Df0tAlDyNvPy58Q= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 73C483858D1E for ; Fri, 29 Apr 2022 01:28:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73C483858D1E Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23T0NJch018650 for ; Fri, 29 Apr 2022 01:28:36 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fqvapnnj7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 29 Apr 2022 01:28:36 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23T1CcTW031178 for ; Fri, 29 Apr 2022 01:28:35 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01dal.us.ibm.com with ESMTP id 3fm93b87vn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 29 Apr 2022 01:28:35 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23T1SX5A38338870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Apr 2022 01:28:33 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D2E6136055; Fri, 29 Apr 2022 01:28:33 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 817D2136059; Fri, 29 Apr 2022 01:28:32 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.152.172]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 29 Apr 2022 01:28:32 +0000 (GMT) Message-ID: <5ee342cd5f5272da9970da8a077c2c5209b85d6c.camel@us.ibm.com> Subject: [PATCH] Fix gdb.cp/no-dmgl-verbose.exp test To: gdb-patches@sourceware.org Date: Thu, 28 Apr 2022 18:28:31 -0700 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: jDc6cj_BW6tyCXU27o7K0YOkUoPXtFsy X-Proofpoint-GUID: jDc6cj_BW6tyCXU27o7K0YOkUoPXtFsy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-28_05,2022-04-28_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 phishscore=0 spamscore=0 mlxlogscore=877 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204290003 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Cc: Ulrich Weigand , Rogerio Alves Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" GDB maintainers: The gdb.cp/no-dmgl-verbose.exp test does a gdb_test which is not written correctly. The test fails on both PowerPC and Intel. The following patch update the gdb_test statement to the correct format. The test now works correctly on PowerPC and Intel. Please let me know if the patch is acceptable for mainline. Thanks. Carl Love ----------------------------------------------------------------------- Fix gdb.cp/no-dmgl-verbose.exp test The test tries to check that setting a break point on f (std::string) fails since the function is not defined. The test is not syntactically correct. The test fails on both PowerPC and Intel. This patch fixes the test to set the breakpoint and verify that it fails since the function is not defined. The test now runs correctly on Power 10 and Intel x86_64. --- gdb/testsuite/gdb.cp/no-dmgl-verbose.exp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.cp/no-dmgl-verbose.exp b/gdb/testsuite/gdb.cp/no-dmgl-verbose.exp index 14f11ddcf04..d4ec88f3b6d 100644 --- a/gdb/testsuite/gdb.cp/no-dmgl-verbose.exp +++ b/gdb/testsuite/gdb.cp/no-dmgl-verbose.exp @@ -28,8 +28,5 @@ clean_restart ${testfile}.o gdb_test_no_output "set breakpoint pending off" -gdb_breakpoint {'f(std::string)'} - -gdb_test {break 'f(std::basic_string, std::allocator >)'} \ - {Function ".*" not defined\.} \ +gdb_test "break 'f(std::string)'" ".*Function.*not defined." \ "DMGL_VERBOSE-demangled f(std::string) is not defined" -- 2.31.1