From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57182 invoked by alias); 17 Jul 2017 10:51:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57172 invoked by uid 89); 17 Jul 2017 10:51:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:929, Keith, keith X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 10:51:41 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 69B20C04B303 for ; Mon, 17 Jul 2017 10:51:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 69B20C04B303 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 69B20C04B303 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D2415C89F; Mon, 17 Jul 2017 10:51:39 +0000 (UTC) Subject: Re: [PATCH 04/40] Fix TAB-completion + .gdb_index slowness (generalize filename_seen_cache) To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-5-git-send-email-palves@redhat.com> <5967DAEA.1060304@redhat.com> <1dbe1bfa-6fe0-0e3c-843c-3f93f87ccb54@redhat.com> From: Pedro Alves Message-ID: <5edec530-329e-a05d-d04d-ce592255889b@redhat.com> Date: Mon, 17 Jul 2017 10:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1dbe1bfa-6fe0-0e3c-843c-3f93f87ccb54@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00221.txt.bz2 On 07/14/2017 08:40 PM, Pedro Alves wrote: > I was about to push it when I realized that I missed releasing the > new heap-allocated dwarf2_per_objfile::filenames_cache... > > To address that, I made it possible for dwarf2_per_objfile to be > a non-POD: > > https://sourceware.org/ml/gdb-patches/2017-07/msg00202.html > > and made dwarf2_per_objfile::filenames_cache an optional, so the > cache object (though not its elements) is on the obstack too. > > Here's the updated patch. The dwarf2_per_objfile patch is in, so I pushed this one in too, with a tiny comment update to mention the reason for the optional: /* Table containing all filenames. This is an optional because the table is lazily constructed on first access. */ gdb::optional filenames_cache; Thanks much for the review, Keith. -- Pedro Alves