From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SJ8HCpliy2AHLAAAWB0awg (envelope-from ) for ; Thu, 17 Jun 2021 10:56:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 1A3161F163; Thu, 17 Jun 2021 10:56:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4ED6A1E54D for ; Thu, 17 Jun 2021 10:56:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06DBF3947C3B for ; Thu, 17 Jun 2021 14:56:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06DBF3947C3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623941784; bh=SXzy0mWZBl9x6Dn7PcYiyXQij5MNsYZd17EHlpEE8E4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UPq8Vl82FLkWEBSsaThRctHnXwvHrQZGhsJR0dvucyG0xsBtuMWjTPNW/sDqFcj9V /gTDqreTRh5Wuzd/+6g2VmC4kVhuQ3sPA47uYCqGLzwbwrJlPQEYUxsaWXnSDwu9iG k3pJklOcN+6+ITplyxWSIYx2vorBl7OSG2UW3Exs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4D10E39730ED for ; Thu, 17 Jun 2021 14:44:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D10E39730ED Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15HEhwl7021190 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Jun 2021 10:44:03 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15HEhwl7021190 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D5E791E54D for ; Thu, 17 Jun 2021 10:43:58 -0400 (EDT) Subject: Re: [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS To: gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <33565c24-0468-1ded-63db-d7ef402d5329@polymtl.ca> Message-ID: <5ece9821-45a3-14f6-33a1-3506b6efe72f@polymtl.ca> Date: Thu, 17 Jun 2021 10:43:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 17 Jun 2021 14:43:59 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-17 12:21 a.m., Mike Frysinger wrote: > On 16 Jun 2021 22:30, Simon Marchi wrote: >> On 2021-06-15 1:44 a.m., Mike Frysinger via Gdb-patches wrote: >>> These dirs don't use automake, so use AC_CONFIG_MACRO_DIRS to specify >>> ../config as a search dir for m4 macros. This allows removal of a lot >>> of hand-written m4_include's from acinclude.m4 files, and simplifies >>> use of `aclocal` or `autoreconf` as manual -I is not needed. >> >> For some reason, I get this when reconfiguring gdb: >> >> configure.ac:531: warning: macro 'AM_ICONV' not found in library >> >> The result looks ok, the resulting configure looks fine, but if you >> happen to know why... > > i don't know why automake is able to find some of the ../config/ m4 files > just fine, but a few others it barfs on. i don't see the warning because > i have gettext installed and automake finds the system iconv.m4. There seems to be a special case for printing that warning for AM_* macros: https://github.com/autotools-mirror/automake/blob/e7724fb1b7b97f662caf154414e6f71ffcbd966c/bin/aclocal.in#L528-L540 I debugged aclocal as much as I could, and it seems to find AM_ICONV just fine, with --verbose I see: aclocal: found macro AM_ICONV in ../config/iconv.m4: 104 Also, note that with `aclocal -I ../config` I do not see the warning... but aclocal does support AC_CONFIG_MACRO_DIRS, so this difference is surprising. So I'd be tempted to call that an aclocal bug, although a benign one. I'd suggest still just doing the right thing and removing all the ../config/* includes, and just ignore the warnings. I'll try to open an automake bug or ask on the mailing list eventually. Simon