From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GGFJMyHiUWeFDQUAWB0awg (envelope-from ) for ; Thu, 05 Dec 2024 12:25:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1733419553; bh=9mk/d1yU7WWXBfawSJ2/1EmI1x01INb0mRoIrHvcwXg=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GLn8/j3jFFp30c0yYpbBcEVyqjZi6imJt33llEw6JH44nGX9IjG7M0BjtXu61jF9v JY3iWFrK9lItU0OoqSYAJW7d0r2hlvr1oN4xjEidxjU+DCh6Kb/w81zPbG58iAmf2l 81470tHgFTB8ux2p8qtB+zyrI4II5aUFcRsvrDUM= Received: by simark.ca (Postfix, from userid 112) id CF4B41E197; Thu, 5 Dec 2024 12:25:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=uxEkcr5i; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=mdnX+T8U; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7590D1E092 for ; Thu, 5 Dec 2024 12:25:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 187E53858CDB for ; Thu, 5 Dec 2024 17:25:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 187E53858CDB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=uxEkcr5i; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=mdnX+T8U Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B58CC3858D20 for ; Thu, 5 Dec 2024 17:25:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B58CC3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B58CC3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733419517; cv=none; b=EmBCRduwuYY/IlL7epimpgfOdqDFjpS9Rps6bRhQASzMfve39UnfQuasGKqWima1JLShK+aWpPzsl/GypGVC1Ds4O8CI6BpGnvui5UNBiaz2qO/tmuF8ayhSW7Pq0YooQOoRYNnEfR3pA/Irjd0ht5qgZRyEXONSp2k6fdz66jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733419517; c=relaxed/simple; bh=9mk/d1yU7WWXBfawSJ2/1EmI1x01INb0mRoIrHvcwXg=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=ss+L/RVXtchjtIWYBOcwBj0w2+3NhTAZVW9ulx+8sdv7WrkN1VbnwwQutc6UAA2+c054oOwlpIDTbEljMeEgnqNJskjeuxDT0HRi3/uOxwKC0a9hyGs5YxfPMbb720zDBgM3cqwyT+LP7tiRETLXByhH5wq4FtK0rJ1VO1JlsG8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B58CC3858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1733419517; bh=9mk/d1yU7WWXBfawSJ2/1EmI1x01INb0mRoIrHvcwXg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=uxEkcr5i/0/SVQ/g9Dx4ikJ6ztZLqeFojrz33R9DQQq/246S5/xoUuKJ+mjr7uyC4 oO1+ihQuSvNUcTzwrXhhTSGSZHEDxpF6W8OYObwfe6QLg+9DQe8TT8Rsm6zeovoVZJ ass2lh5Yt17GfFDtroLEiuLgamudSqm2zgrFLFVQ= Received: by simark.ca (Postfix, from userid 112) id 647D41E197; Thu, 5 Dec 2024 12:25:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1733419516; bh=9mk/d1yU7WWXBfawSJ2/1EmI1x01INb0mRoIrHvcwXg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=mdnX+T8UY32pu9i3QiLJuNoNHSlFUuBT5ZfCzZ5kyGsfHlbmUink0EJ83ABrpjk01 gdSjXCA7eOsLaAThiWlxvVJ3cSyBN1NXfhNXj+H+g5ziyb7Af+yWC9+D2kNqtsiY1r U4ytvfMcZfQxmQLRRoBMhAa5C2jKgb6oMZSLXTJ0= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C12EC1E092; Thu, 5 Dec 2024 12:25:16 -0500 (EST) Message-ID: <5eb4ee44-8ae7-4fcc-8b1a-ee8c47ab86f2@simark.ca> Date: Thu, 5 Dec 2024 12:25:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Create script to convert old tests into Dwarf::assemble calls. To: William Ferreira , gdb-patches@sourceware.org References: <20241205135550.9320-1-wqferr@gmail.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20241205135550.9320-1-wqferr@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-12-05 08:55, William Ferreira wrote: > PR testsuite/32261 requests a script that could convert old .S-based > tests (that were made before dwarf.exp existed) into the new > Dwarf::assemble calls in Tcl. This commit is an initial implementation > of such a script. Python was chosen for convenience, and only relies on > a single external library. Thanks for doing this. I don't have time for a deep review right now, but I have a few superficial comments. I'm not sure I would put it under testsuite/lib. This directory contains stuff used by the tests themselves (expect code) of test programs. Maybe right under testsuite? There are already two Python utils there. Run black and flake8. I would suggest setting up pre-commit for that: https://sourceware.org/gdb/wiki/DeveloperTips#Setting_up_pre-commit However, the flake8 entry in .pre-commit-config.yml isn't properly set up to pick up gdb/testsuite/*.py, I will try to fix that right now. > +def main(argv): > + try: > + filename = argv[1] > + except IndexError: > + print("Usage:") > + print("python ./asm_to_dwarf_assembler.py ") > + sys.exit(1) You import argparse but don't use it. Any reason not to use it? Simon