From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8C84E385EC58 for ; Wed, 1 Jul 2020 00:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8C84E385EC58 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2FDC71E797; Tue, 30 Jun 2020 20:36:38 -0400 (EDT) Subject: Re: [PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5 From: Simon Marchi To: Caroline Tice , Tom Tromey Cc: Eric Christopher , Caroline Tice via Gdb-patches References: <87lfl634rs.fsf@tromey.com> <87h7vsqk5h.fsf@tromey.com> <87h7v815n7.fsf@tromey.com> Message-ID: <5eab18a1-c7e9-1a77-7f65-944eea10aa85@simark.ca> Date: Tue, 30 Jun 2020 20:36:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 00:36:39 -0000 On 2020-06-30 8:34 p.m., Simon Marchi wrote: > On 2020-06-23 3:04 p.m., Caroline Tice via Gdb-patches wrote: >> I believe I have addressed all of your comments. The updated patch is >> attached. Please let me know if this is ok now. Thanks! > > Hi Caroline, > > Just to be sure, could you please send the complete patch, including the commit message (using > either git-format-patch or git-send-email)? It would be nice to see the patch as it will be > merged, which includes the commit message. > > Simon > Oh, and just a nit, git told me this when applying: /home/simark/patches/gdb-dwo-rnglists.updated2.patch:188: space before tab in indent. default: warning: 1 line adds whitespace errors. Simon