From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 367 invoked by alias); 13 Jul 2017 19:09:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129794 invoked by uid 89); 13 Jul 2017 19:08:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-lf0-f48.google.com Received: from mail-lf0-f48.google.com (HELO mail-lf0-f48.google.com) (209.85.215.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jul 2017 19:08:58 +0000 Received: by mail-lf0-f48.google.com with SMTP id b207so42106278lfg.2 for ; Thu, 13 Jul 2017 12:08:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aNvLYwkEs1AeidRkVwQponl0WrMhGMUIA8z9T+9nJrk=; b=d1hwHG1CHO5jH4u8+95lXIYQ/MXvRJiv7OaDO8Lq722mKHje2Ur3agnzo2vZwWj8Aq YEWZX3MJOEGXiW0pUyDD4k21FUZ4iD6qdDLQlrYbnLp0lxvEsF0UG6REMsRoLeIl/EYY TvAtCktQVkZL3gPgLno+jonBGdpQFhBy4VsiSrWFcNkk5ACqoU7gR8ZlRgLTl3mR/aY3 koHufpvo9hEp2Rj7Rvs/if1NydBTQZd0Dczo6+fGbfiIAl1uGzvcne3aAf96ISejhXLm 49MHKs7dhvjmk/ziik2SvVU/QPJIX7dMR5dPTqTi58W9cvEVQ1LnbQPeXqqv2ZOJCK1J 7wkQ== X-Gm-Message-State: AIVw113MVX1vLh3f/+myS/K0cI2ERnao/cs+OG46RoX7fuR3hYDao2o5 t37u/7SuZbngz94GjkA= X-Received: by 10.46.77.130 with SMTP id c2mr1519087ljd.12.1499972935500; Thu, 13 Jul 2017 12:08:55 -0700 (PDT) Received: from [192.168.0.204] ([91.215.122.25]) by smtp.gmail.com with ESMTPSA id h38sm1471106lfi.33.2017.07.13.12.08.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 12:08:54 -0700 (PDT) Subject: Re: [PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <83vamwgwf5.fsf@gnu.org> <7bf49b91-2af6-c99b-174d-050348e28227@gmail.com> <83iniwgnv3.fsf@gnu.org> From: Ruslan Kabatsayev Message-ID: <5e7030db-1254-faca-62eb-ca5e3ada8a5a@gmail.com> Date: Thu, 13 Jul 2017 19:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <83iniwgnv3.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00164.txt.bz2 On 13/07/17 22:04, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Ruslan Kabatsayev >> Date: Thu, 13 Jul 2017 21:19:10 +0300 >> >>>> gdb/ChangeLog: >>>> >>>> * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list >>>> * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode >>> >>> This is fine with me, but please state in the ChangeLog the >>> functions/globals where you make the changes, and for gdb.texinfo >>> please state the name of the node (in parentheses). I think the >>> existing ChangeLog entries show how we do that. >> >> gdb/ChangeLog: >> * tui/tui.c (tui_commands): Add "nexti" and "stepi" to the tui_commands list >> * doc/gdb.texinfo (TUI Single Key Mode): Document the new shortcuts in >> Single-Key mode > > Yes, that's it, except that the lines should be broken at column 75, > and there should be a period at the end of each sentence. gdb/ChangeLog: * tui/tui.c (tui_commands): Add "nexti" and "stepi" to the Single-Key mode command list. * doc/gdb.texinfo (TUI Single Key Mode): Document the new shortcuts in Single-Key mode. > > Thanks. >