From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51564 invoked by alias); 27 Jun 2017 12:03:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51059 invoked by uid 89); 27 Jun 2017 12:03:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=stands X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 12:03:00 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73A97A23D3; Tue, 27 Jun 2017 12:02:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 73A97A23D3 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 73A97A23D3 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD3457A311; Tue, 27 Jun 2017 12:02:58 +0000 (UTC) Subject: Re: [PATCH 05/40] command.h: Include scoped_restore_command.h To: Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-6-git-send-email-palves@redhat.com> <86bmp9fz0z.fsf@gmail.com> <684b5ca4-590b-d375-93f5-b66e86ec33a1@redhat.com> <6314192d-2f8e-cfd1-18ea-362cf2b59374@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5e659d80-8e34-5733-5a15-3b683c0c1906@redhat.com> Date: Tue, 27 Jun 2017 12:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6314192d-2f8e-cfd1-18ea-362cf2b59374@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-06/txt/msg00724.txt.bz2 On 06/27/2017 12:52 PM, Pedro Alves wrote: > I don't remember exactly where I added the #include "command.h" that > triggered this. Must have been somewhere that caused "command.h" to > be included via "defs.h", before the "#include utils.h" line. > > Let me try removing it from the series, see if I can still reproduce it. Found it. Patch #11 (https://sourceware.org/ml/gdb-patches/2017-06/msg00023.html) later does: diff --git c/gdb/symtab.h w/gdb/symtab.h index 5901cf9..fb08479 100644 --- c/gdb/symtab.h +++ w/gdb/symtab.h @@ -25,6 +25,7 @@ #include "gdbtypes.h" #include "common/enum-flags.h" #include "common/function-view.h" +#include "completer.h" which without this fix would break building all .o files like this: In file included from src/gdb/completer.h:21:0, from src/gdb/symtab.h:28, from src/gdb/language.h:26, from src/gdb/frame.h:72, from src/gdb/gdbarch.h:39, from src/gdb/defs.h:636, from src/gdb/top.c:20: src/gdb/command.h:434:8: error: ‘scoped_restore_tmpl’ does not name a type extern scoped_restore_tmpl prevent_dont_repeat (void); ^ Makefile:1911: recipe for target 'top.o' failed because completer.h includes command.h, and that include chain happens before utils.h is included at the end of defs.h. I think it'd be good if defs.h didn't pull in so much, but I think that's orthogonal, and the current fix stands on its own. I should have included this info in the original submission. Sorry about that. Thanks, Pedro Alves