From: Guinevere Larsen <guinevere@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 3/3] GDB: Introduce "info namespaces" command
Date: Mon, 14 Apr 2025 09:13:18 -0300 [thread overview]
Message-ID: <5e544739-5a5b-4c78-8378-ba279f2019bc@redhat.com> (raw)
In-Reply-To: <20250412172055.16ca7462@f41-zbm-amd>
On 4/12/25 9:20 PM, Kevin Buettner wrote:
> A nit regarding the title/subject of this commit: It should be:
>
> GDB: Introduce "info linker-namespaces" command
>
> Aside from that, it looks okay to me.
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
I ended up sending a v3 of this patch series, with the only change being
to the test of this last patch, that you can find here:
https://inbox.sourceware.org/gdb-patches/20250411175022.2379494-4-guinevere@redhat.com/T/#u
To summarize the changes, in Ubuntu (and maybe other systems), libm and
libc may not be loaded into the namespaces, so 12 failures would happen.
Linaro CI pointed these out (albeit with some large delay). I have fixed
and added your approvals to the patches, but I'll wait until friday to
make sure that you (or anyone else) had time to comment on the new
version, and that Linaro CI had time to run the tests.
--
Cheers,
Guinevere Larsen
She/Her/Hers
prev parent reply other threads:[~2025-04-14 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 20:44 [PATCH v2 0/3] Add some linker namespaces conveniences Guinevere Larsen
2025-04-09 20:44 ` [PATCH v2 1/3] gdb: add convenience variables around linker namespace debugging Guinevere Larsen
2025-04-12 23:49 ` Kevin Buettner
2025-04-13 0:22 ` Kevin Buettner
2025-04-09 20:44 ` [PATCH v2 2/3] gdb: factor out printing a table of solibs for info sharedlibrary Guinevere Larsen
2025-04-13 0:02 ` Kevin Buettner
2025-04-09 20:44 ` [PATCH v2 3/3] GDB: Introduce "info namespaces" command Guinevere Larsen
2025-04-13 0:20 ` Kevin Buettner
2025-04-14 12:13 ` Guinevere Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e544739-5a5b-4c78-8378-ba279f2019bc@redhat.com \
--to=guinevere@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox