From: Pedro Alves <palves@redhat.com>
To: Alan Hayward <Alan.Hayward@arm.com>, Simon Marchi <simark@simark.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] Testsuite: Ensure pie is disabled on some tests
Date: Tue, 19 Mar 2019 16:36:00 -0000 [thread overview]
Message-ID: <5e4ffe85-1835-5d65-9c04-019e2f6769bc@redhat.com> (raw)
In-Reply-To: <260313A3-D685-4306-8DE1-080D51BAE0BE@arm.com>
On 03/19/2019 03:45 PM, Alan Hayward wrote:
> + # Recent Debian/Ubuntu defaults to PIE enabled. Ensure it is disabled.
> + lappend opts {nopie}
Please don't write "Recent", "New", etc. Imagine it's 2025 and you're
reading this comment. What would "Recent" mean then? Spell out some
version number where you observed this instead.
Thanks,
Pedro Alves
prev parent reply other threads:[~2019-03-19 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 10:20 Alan Hayward
2019-03-19 10:45 ` [PING][PATCH] " Alan Hayward
2019-03-19 13:48 ` [PATCH] " Simon Marchi
2019-03-19 15:45 ` Alan Hayward
2019-03-19 16:07 ` Simon Marchi
2019-03-20 10:36 ` Alan Hayward
2019-03-19 16:36 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4ffe85-1835-5d65-9c04-019e2f6769bc@redhat.com \
--to=palves@redhat.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox