From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70329 invoked by alias); 22 Mar 2018 20:28:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70318 invoked by uid 89); 22 Mar 2018 20:28:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 20:28:21 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 2D.F9.06525.1E114BA5; Thu, 22 Mar 2018 21:28:18 +0100 (CET) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSHC005.ericsson.se (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 22 Mar 2018 21:28:15 +0100 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Thu, 22 Mar 2018 21:28:16 +0100 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Thu, 22 Mar 2018 21:28:16 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.63] (192.75.88.130) by SN6PR1501MB2013.namprd15.prod.outlook.com (2603:10b6:805:d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Thu, 22 Mar 2018 20:28:13 +0000 Subject: Re: [PATCH 2 PR gdb/16959] gdb hangs in infinite recursion To: Weimin Pan , References: <1521740517-56879-1-git-send-email-weimin.pan@oracle.com> From: Simon Marchi Message-ID: <5e33d0dc-8810-ff04-6bed-106ace62621c@ericsson.com> Date: Thu, 22 Mar 2018 20:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521740517-56879-1-git-send-email-weimin.pan@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR14CA0029.namprd14.prod.outlook.com (2603:10b6:404:13f::15) To SN6PR1501MB2013.namprd15.prod.outlook.com (2603:10b6:805:d::32) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cde9fb75-448d-452c-d95e-08d590336fff X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:SN6PR1501MB2013; X-Microsoft-Exchange-Diagnostics: 1;SN6PR1501MB2013;3:+Wcxi1jK4Vm7WjGgKkt6cI4cgG+M5zpQeP1ffwddFgDfP6dW7aN5Zgzb1IQ2b5gP7s96eUn/bIqL4oYw4MAlEwUk0xAvSNmFViM27Ps1Ni20Jjrl7GdfK2o+DFygS4xKkQYY8V3DNhxreAbYGhz2rBeiYYv/2OnyyN9ki7/3jwegn4xK8HIxGvL7jBaDtW9+D9jrbZKsyx/OQ87vA8VZglJHjXt0wWFCjXBtMUo0QDeW25AvidMKgFmY6ZBSu/aw;25:aqVdKOSK3St3f3O+cqjvs992rofD0zSOn6eVh0P1Y9P9NR0Vp1Jx3656tVwA11o1Tzwf8WRf3JBJz61CGxxiMZuOAfejM2A8leccO8nodOZHrNYD+O3oVLo5dCpkPlRBtbjMsLLjnhIjjsjSPcEJKuFgm0gISXhkYfx5DwHI7oCSQKyeJxGNCPpTAVYK2s2mpl7rmm9Q0SmGPKyn5HrdsF0IztEdGbgsiThegbJtF1ZYdr8agB+Scy09InFOomXM31RPmFK3xjGU7QMFsVlLjHqFMhdYUYqKGStXx3vCzic5c46IEdRJUcY0aOlUmwvI0AwsGhLQoS04p10a5kaeHw==;31:+t0CNDqy/5D7GPAuTziWUvkQUMxBsN3BuefqWB3+wP64zakEQQoRe1/Cnoe6aBd504zz8W4iimPwetphGmKackhfJytyiJuvZBjsCoCcVwI3/Gpsl3jIW+z15lA31O2gMdoRilEaVP3a4+GqmMVvrArh5yLffbDo3AGRzklN7qdJu3imT5T72F+issfI3/prahu4AFTJ0uX2lRZlNWFG635Wr31zjXzEcC3nATcRfkE= X-MS-TrafficTypeDiagnostic: SN6PR1501MB2013: X-Microsoft-Exchange-Diagnostics: 1;SN6PR1501MB2013;20:IJP+vzQrpex5PlrG8n7fig5GUzzoNC6Qbwj0RVujqngCLFawB0yvUeeMHPT9fAwaAarxYUoPURkV+X3HIEIuVT9ubLxKJnQdMHk6TF4Pk6N7x7FLoNqs5ASFxiLIcUYwHYKqBHdOHpmbOobvV2zuKkXvePyu2ql5sAfmxRDIofV5Jllv0IU92Rdr5x966bNJezUT0n8Mfxa0G+SMWIqwtDXF7SJCV9gyugxg/iwos9yEEqMXywGUMdvlwMnZi49Eu3CtzXKHn68FupKhVdylJJ8B8PTs0slMezuul/D+qv3fcWUk8NcUBDw+tX7NlVyWOXwukDnBqN+NFtXAgEAGawQ4Of90n59fZowJ8jBWN0fE1bjRydXf9T8o9gve452X5tgdpfHD42d/qqwveFx+0PyqSJLRcVLl7/H30ddcpizgixvpRHFyCrWXpBw5MWMviWG/N+Mn7sWR5bsgnBl7ZEZHYAk02+q9Ckpb7R6PqCdCmc37qRXyU9C7em34oo+2;4:GR81Tcao4YKjHMsCl7RUedXcJenYEA5VMiZFawhdiHrQSo8skcbLFxPvJz4+xXno4Uk0Ba2MP69SbrcdZOmI0ML3ZYmhh3Vo6vQxZMcP9zIjn9/mMm7K3E4m7k1Y3uFcYaa9FxwO/ys5IAyT3tvZfx2ixVVFmtyn3dbjHVSX58i5EX+iJTeZf8pP4E37S1okHGMJEGZTF7ZWx0Ks07fA8s9ERttGnFHwDyz45s2CStLZyAItSmAz+AEf0v+QmFWWkBMK98A44MqB0TYeVQSe+yh64sJqUXyQPdbD7ZDfiXt5uuScEhuHTJzyMljacoL6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:SN6PR1501MB2013;BCL:0;PCL:0;RULEID:;SRVR:SN6PR1501MB2013; X-Forefront-PRVS: 0619D53754 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(396003)(39380400002)(376002)(39860400002)(346002)(377424004)(54534003)(189003)(199004)(16576012)(106356001)(86362001)(6666003)(76176011)(229853002)(53546011)(49976009)(575784001)(386003)(186003)(31686004)(36756003)(16526019)(446003)(52116002)(52146003)(23676004)(316002)(58126008)(2486003)(53936002)(105586002)(26005)(6246003)(6486002)(97736004)(81156014)(8936002)(81166006)(3846002)(25786009)(68736007)(65826007)(8676002)(478600001)(230700001)(31696002)(7736002)(305945005)(6116002)(65806001)(2906002)(5660300001)(64126003)(66066001)(50466002)(47776003)(65956001)(11346002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR1501MB2013;H:[142.133.49.63];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjE1MDFNQjIwMTM7MjM6ZUF0Ujg3VS9oV3o5NHVUalIzZDd4M3dj?= =?utf-8?B?aC93d3k3dUZGb0xWd1RMdzZiZGVLTWJCNUZPZUZyemxUb3VTVUJvVldudlJt?= =?utf-8?B?cG83STRYRVEvbEp3ODcwZ0lucDVnSlY5L1AvSDJNQnNqOWVoVU9oY3FUVHVi?= =?utf-8?B?WW1oKzl1KysxVmhaS2Z0ZHJ6a3NiVmsxQmt6U2hXTkkxTW9XYjZQcW1Pbjl0?= =?utf-8?B?dDhsU0txanc3bHFVdExZL3F1RExOS2lmK3BVYWZXL2p3TUYyUXJwbDBsRDY3?= =?utf-8?B?OUE5QXJSSWI5OFp3ZmNRUG05ZVFrVjE1VjdtZ1NRY0hVaGVDMjA4NnFPWFFp?= =?utf-8?B?VlUxSUtqaU1DcXpiSGpiVFlTNlNibUh0MlV2eElUbmQrYkIvL2dOeGw3anFJ?= =?utf-8?B?NUgyL0Z4LzZmMHNBNGxXM2d6Vk5SbmRaYWJpek9mODVkc1Y0MTdnOFZyS0tV?= =?utf-8?B?Q0c0dWN0SzVEVzJhWWttMXNuTzZmb3crdFZlZWMvNFgydHArN3NyZmNuQXhD?= =?utf-8?B?bTNZbVNUd0M2ZVRndmg4U0h0S0FPV2tFSFppYjZ0ZDJIMC85QytkcXNKb2s2?= =?utf-8?B?cVJBUWZ6eGxzQ0poVkFlRFhtMk1vVFBFYjJkZ3JCdmVmcmtQMWQxUTZXV3BP?= =?utf-8?B?cTRqQ0tDL2YzTDcwcHBWQXcyVnVMOGV3ZjYvQzI1Z0s1QzZQdzNRRnI0VndI?= =?utf-8?B?R1Z6NjR6V3JRRFNnaUg4bkZoeFJLMEpGemcvZk10MElCT1g0Uzhadnd0ak95?= =?utf-8?B?dU1KRWM2RFB1aG5kNGw0eDBxNlcwQUM1dUV0YVpOOWZHanZJdjEvV1ZldTlG?= =?utf-8?B?MDVvU0NKdGVYZ2p5MkVLempsaFBhUVJZalhpV0Q0SkM2RUdiNXE3VGpQY0cx?= =?utf-8?B?b29NS2NFNmo1ZnY4L3kzUVNNU0JlZk5ORFNnVUhBS0tQUjc1bDJKV2dnR3Av?= =?utf-8?B?ek12bDJTdy9FSUtFNHdIK0tycHBSeWlRYXpUR0RvN0NpNGo3b0ROYXFnUjlU?= =?utf-8?B?NnQyc21kSWdOdXY3aXFDS2Z0QWF6SkQ1S1RzdDRkUkduOWN1Z3Rwcy9XNFJD?= =?utf-8?B?dTB2VFFmZEZxdUR4Q0hUK0FmS2pVTUcwaU1mNElGL0d1dWVuOUMxZHBKazEz?= =?utf-8?B?M1ZoMmgwUlE4K1ZjQVVtNWp2ZkVnM1A3bFlCT2xSMjl5eWFVUlZBUTMvdW9Q?= =?utf-8?B?WjBwTTlLZ2tiNHN6QnBnTTlOMUUzanVKS2Fza3Rva2xPeWRWYkN1ZUdVZCtM?= =?utf-8?B?VWJQOHMrUEhwbnNGRHJZbWhKSjBnUjVrQlpCcXliZVI1bWlSeDloWmtrVm9E?= =?utf-8?B?TzNrQVVSalI1RkJHYkI5NlJYdTNmbmtDaDNmQ2sxa2NrVE1ZOWxzUjJxZjl3?= =?utf-8?B?cUZEWXhKTjdjVWJMeVpZTjRhRUVROWp5WVB1VWlvL2xJaCtmVzJpak1GVHdP?= =?utf-8?B?N1p6dGhDSE5IZVMvQjNrUGF4cmZoTEpjNER3QnRVWG1PbDRGb0tEYTZLaDVF?= =?utf-8?B?ODZyczJXMllOVit4eFNSTzc3d1YzTWswQmZoL2lRREN4U2tGVkNxUWdScHV3?= =?utf-8?B?ejUyVW13UGdNTUJIekxNcUZaWXJGYmdPRW5zRHVPeE1FTmttODlES24xTmcr?= =?utf-8?B?SXprNFRwMUtTMjAvK0dFdlB2NmREMk50ck1yNXBJZFFsU1hlSElaQ3AyQjA0?= =?utf-8?B?ZVdjTkFoMS9vM3hhZlllWERqejlPTFBCQldwWXcrT1FaZkhKMXhsMVoxN281?= =?utf-8?B?TEduWnQ0Q3hTRkxzdVZjWmdvaHZyL20xZ3dmNUIxS2k2dlVxdUl6b3lpYm1T?= =?utf-8?B?UUJRcGhmQW5ZN0huT3pMM0tLY1EzM1ZIQmRSUjJpV2k3cFRQRjVTYjkzNkNN?= =?utf-8?Q?ubkV2I+BcGrgrA/ZtFwGKyaa5LRT8qE/er?= X-Microsoft-Antispam-Message-Info: WcesPJp8lL//FRtiehmpVxZ+7vSf4KTLLmLMl1mFbsMGGr9W264IAX7XMCO+Zq1GkhLxGj0p4Acs7L4TXRg2Oja3UHkQ5AbrgcRKRRiyd/2C8PMWMi+O/3rfkIJhS3h0wB+ZUog4Z1wjiGynfeTTa5mp2abyYhatyPUXnm9bDa2SCBQFfDHmPFY3mjUR+M85 X-Microsoft-Exchange-Diagnostics: 1;SN6PR1501MB2013;6:w391mF8VfRzrLmneAzF6APDwylXgM/G24+6ZuTqPkK0/0iJtA2N+w18tWZH/oex5+rurWR/am1uAKZVVKo8H5dfMWlgl/aAdrUIDO+osAXyP0+7qq55YknPULc8gu2yM2JK+2XO2wBPeWXBFM+Q6ZQ5HdSxW4SfAWE6rS7q8tZTLJWtMouVni7mf52f0KUAcftyQCvncQv0P3vZMjdmhCGJEQESZzUr2djg3raNCJ28MJNTbOn3d/IbIpFla+KEYJ6Qcy9XMEox57fX6bFuJR/iTk64BuAKKVcUDCIAzlSkVoV3Yn2bvx5LvPTeMj13O0O7Y5jw/FOPuJ5pM1fraMJBwQpzVDPFZ6RQw3MR8wno=;5:BqKZEdYfBHjx4qTRozsLJfbliSkWoYdTAP6v4rY1FIsOmVVBtrra6HiV/o1vGWZB0aCy+VkDcdx0tiIdoTusj+0izN6TGPV3d5KCvY3Tnfjic6V5uPPibx3XsEARMR9aHtVWg0DvcDGSaJi8MlWWKEw2BXNbzovKpegJPzOiT+Y=;24:DMwzq9GrnPxM4AKmmstmc/k2Ff7u5KwrIr6pDxvP1YpBmNYS5qkuOQ8cdn60qm/sUMex6XOWJLuznKuriuu5x1JO9KsgRWVkSbQ888CO6RQ=;7:BCsW98qq+71VKUan9UEot9XJIK2w/OHAceBKsg6DfgTWqMD+Y5If/dvfhiVK5sc9dHBBzFaLkliQU9broRf6Nzej3AHRrCA4fB0NkAVGv+0wkjr2TkSljldyULe/xY8tZWdElKR5xJz2bBTqax+CAda0z7YDi2k6YVTlzukNImGXto5/lup13Rs7Fe7RbelzLTqNWTdxu5VnUCuc15vEgYjaaL+k4l/roK3RKj8scVn4y+YCMhxM/OTbotpI0udW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2018 20:28:13.7219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cde9fb75-448d-452c-d95e-08d590336fff X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR1501MB2013 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00429.txt.bz2 On 2018-03-22 01:41 PM, Weimin Pan wrote: > The original problem was fixed (see related PR 22242). But using a typedef > as the declared type for a static member variable, as commented in this PR, > is still causing gdb to get into infinite loop when printing the static > member's value. This problem can be reproduced as follows: > > % cat t.cc > class A { > typedef A type; > public: > bool operator==(const type& other) { return true; } > > static const type INSTANCE; > }; > > const A A::INSTANCE; > > int main() { > A a; > if (a == A::INSTANCE) { > return -1; > } > return 0; > } > % g++ -g t.cc > % gdb -ex "start" -ex "p a" a.out > > The fix is rather trivial - in cp_print_static_field(), should call > check_typedef() to get the static member's real type and use it to > check whether it's a struct or an array. > > Added a new test case to the testsuite as Simon suggested. > > Tested on both aarch64-linux-gnu and amd64-linux-gnu. No regressions. > --- > --- > gdb/ChangeLog | 7 ++++ > gdb/cp-valprint.c | 2 +- > gdb/testsuite/ChangeLog | 5 +++ > gdb/testsuite/gdb.cp/static-typedef-print.cc | 35 +++++++++++++++++++++ > gdb/testsuite/gdb.cp/static-typedef-print.exp | 40 +++++++++++++++++++++++++ > 5 files changed, 88 insertions(+), 1 deletions(-) > create mode 100644 gdb/testsuite/gdb.cp/static-typedef-print.cc > create mode 100644 gdb/testsuite/gdb.cp/static-typedef-print.exp > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index d0a8dfd..6fd43de 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,10 @@ > +2018-02-07 Weimin Pan > + > + PR gdb/16959 > + * cp-valprint.c: (cp_print_static_field) Use check_typedef() to get > + static member's real type for TYPE_CODE_STRUCT and TYPE_CODE_ARRAY > + comparisons. > + > 2018-01-24 Pedro Alves > > GCC PR libstdc++/83906 > diff --git a/gdb/cp-valprint.c b/gdb/cp-valprint.c > index 486653f..0370b56 100644 > --- a/gdb/cp-valprint.c > +++ b/gdb/cp-valprint.c > @@ -633,6 +633,7 @@ cp_print_static_field (struct type *type, > return; > } > > + type = check_typedef (type); > if (TYPE_CODE (type) == TYPE_CODE_STRUCT) > { > CORE_ADDR *first_dont_print; > @@ -658,7 +659,6 @@ cp_print_static_field (struct type *type, > addr = value_address (val); > obstack_grow (&dont_print_statmem_obstack, (char *) &addr, > sizeof (CORE_ADDR)); > - type = check_typedef (type); > cp_print_value_fields (type, value_enclosing_type (val), > value_embedded_offset (val), addr, > stream, recurse, val, I pointed this out in my previous mail: type is passed below to val_print. I think it would be better to continue passing the original type to that function instead of the resolved type. It could affect how things are printed (if the type name is printed somewhere, or if pretty printers are involved). Many functions use a variable "real_type" to hold the result from check_typedef, you could follow that pattern. Did you have a chance to take a look? Simon