From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105801 invoked by alias); 26 Jun 2019 03:55:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105792 invoked by uid 89); 26 Jun 2019 03:55:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jun 2019 03:54:59 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E0672ABC2; Wed, 26 Jun 2019 03:54:56 +0000 (UTC) Subject: [committed][gdb/testsuite] Add back missing debug for index-cache.exp To: Sergio Durigan Junior Cc: Pedro Alves , gdb-patches@sourceware.org, Simon Marchi References: <20190621152742.GA20230@delia> <62bf83ef-0c18-12a8-bfb0-8f3f28fa84ba@suse.de> <31086b56-cffc-140a-bb5c-fc22151ba379@redhat.com> <87mui5scx1.fsf_-_@redhat.com> From: Tom de Vries Message-ID: <5e25f29f-90a9-de6c-d7c4-5c48e14f1179@suse.de> Date: Wed, 26 Jun 2019 03:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87mui5scx1.fsf_-_@redhat.com> Content-Type: multipart/mixed; boundary="------------B610D0B23547C958AEF34F17" X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00591.txt.bz2 This is a multi-part message in MIME format. --------------B610D0B23547C958AEF34F17 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 985 [ was: Re: Testcase regression (gdb.base/index-cache.exp) on x86_64 (was: Re: [PATCH][gdb/testsuite] Compile index-cache.c with -Wl,--build-id) ] On 25-06-19 21:06, Sergio Durigan Junior wrote: > On Friday, June 21 2019, Tom de Vries wrote: > >> Thanks for the review, I've updated the rationale. >> >> I'll commit in a bit unless there are further comments. > > Hi Tom, > > This has caused a testcase regression on x86_64. It was caught by the > BuildBot: > > https://sourceware.org/ml/gdb-testers/2019-q2/msg06515.html > > The failures are: > > PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats > PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created > PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: check index-cache stats > PASS -> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is there > Fixed by patch attached below. Committed. Thanks, - Tom --------------B610D0B23547C958AEF34F17 Content-Type: text/x-patch; name="0001-gdb-testsuite-Add-back-missing-debug-for-index-cache.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Add-back-missing-debug-for-index-cache.ex"; filename*1="p.patch" Content-length: 1193 [gdb/testsuite] Add back missing debug for index-cache.exp The proc prepare_for_testing has "debug" as default argument for the options parameter. In the commit c596f180a1 "[gdb/testsuite] Compile index-cache.c with -Wl,--build-id", by setting the options argument we've effectively dropped "debug". This causes index-cache.exp to not contain any debug info anymore on most systems (though not on openSUSE), which causes index-cache.exp FAILs. Fix this by adding back the missing "debug" option. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2019-06-26 Tom de Vries * gdb.base/index-cache.exp: Add back missing debug option. --- gdb/testsuite/gdb.base/index-cache.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp index 6f1488e037..f14cbb01ef 100644 --- a/gdb/testsuite/gdb.base/index-cache.exp +++ b/gdb/testsuite/gdb.base/index-cache.exp @@ -19,7 +19,7 @@ standard_testfile if { [prepare_for_testing "failed to prepare" $testfile $srcfile \ - {additional_flags=-Wl,--build-id}] } { + {debug additional_flags=-Wl,--build-id}] } { return } --------------B610D0B23547C958AEF34F17--