From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21660 invoked by alias); 21 Jun 2017 12:43:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21601 invoked by uid 89); 21 Jun 2017 12:43:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-Greylist:succeeded, HX-Greylist:SMTP, HX-Greylist:AUTH X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 12:43:33 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (d-24-245-127-120.cpe.metrocast.net [24.245.127.120]) by mail.baldwin.cx (Postfix) with ESMTPSA id E00F310AF01; Wed, 21 Jun 2017 08:43:30 -0400 (EDT) Subject: Re: File name convention ARCH-OSABI-tdep.c To: Yao Qi , gdb-patches@sourceware.org References: <868tklhct8.fsf@gmail.com> Cc: weimin.pan@oracle.com From: John Baldwin Message-ID: <5dfce3b5-525d-4afa-ef26-81f98534a78a@FreeBSD.org> Date: Wed, 21 Jun 2017 12:43:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <868tklhct8.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00591.txt.bz2 On 6/21/17 6:09 AM, Yao Qi wrote: > > Hi, > I want to extend the *-tdep.c file name convention. The current > convention is ARCH-OSABI-tdep.c, and I want to extend it to > ARCH-OSABI-tdep-FUNC.c, in which FUNC is about a certain functionality > or feature about this target. > > The sparc64 adi patch > (https://sourceware.org/ml/gdb-patches/2017-06/msg00472.html) adds a new > file sparc64-adi-tdep.c which should be merged to sparc64-tdep.c > according to the current naming convention. However, I think it is good > to put different things in different files. So with the new convention > proposed here, the new file can be sparc64-tdep-adi.c. > > Secondly, some *-tdep.c files are already quite large, arm-tdep.c is of > 399434 bytes, 13318 lines. It is the 5th largest file. arm-tdep.c > includes many things which are not related to each, like displaced > stepping and process record. I am thinking that we should allow people > moving them out of *-tdep.c to *-tdep-displaced.c and *-tdep-precord.c. I like this idea. In my FreeBSD kgdb patches I have been putting the kernel-specific bits (custom frame unwinders, etc.) in files named ARCH-OSABI-kern.c. I would be happy to place those in ARCH-OSABI-tdep-kern.c instead. -- John Baldwin