From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11139 invoked by alias); 6 Oct 2014 09:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11130 invoked by uid 89); 6 Oct 2014 09:06:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bn0107.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Oct 2014 09:06:42 +0000 Received: from BY2PR03MB175.namprd03.prod.outlook.com (10.242.36.148) by BY2PR03MB176.namprd03.prod.outlook.com (10.242.36.153) with Microsoft SMTP Server (TLS) id 15.0.1044.10; Mon, 6 Oct 2014 09:06:37 +0000 Received: from BY2PR03MB175.namprd03.prod.outlook.com ([169.254.5.56]) by BY2PR03MB175.namprd03.prod.outlook.com ([169.254.5.56]) with mapi id 15.00.1044.008; Mon, 6 Oct 2014 09:06:37 +0000 From: "catalin.udma@freescale.com" To: Pedro Alves , Yao Qi , "Andrew Pinski" CC: Richard Earnshaw , Philippe Waroquiers , "gdb-patches@sourceware.org" Subject: RE: [PATCH] aarch64/gdbserver: fix floating point registers display Date: Mon, 06 Oct 2014 09:06:00 -0000 Message-ID: <5de239127f114c65848525ab019de76d@BY2PR03MB175.namprd03.prod.outlook.com> References: <1407835166-827-1-git-send-email-catalin.udma@freescale.com> <53E9E1C2.6010707@arm.com> <53E9EB9A.7000304@codesourcery.com> <1407932734.2182.67.camel@soleil> <53EB5C86.4030307@codesourcery.com> <53EB7965.8070208@arm.com> <53F4DC74.8080807@redhat.com> <85303e79d83947958b01132bc0613e72@BY2PR03MB175.namprd03.prod.outlook.com> <53F59F12.1010007@codesourcery.com> <53F618B3.5040508@redhat.com> <542BCE71.5080308@redhat.com> In-Reply-To: <542BCE71.5080308@redhat.com> x-ms-exchange-transport-fromentityheader: Hosted x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB176; x-forefront-prvs: 03569407CC x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(51704005)(199003)(189002)(15975445006)(19580395003)(21056001)(99286002)(85306004)(93886004)(80022003)(64706001)(20776003)(46102003)(122556001)(31966008)(107046002)(106356001)(40100001)(105586002)(106116001)(95666004)(99396003)(77096002)(74316001)(85852003)(66066001)(54356999)(76576001)(33646002)(2656002)(87936001)(76176999)(10300001)(76482002)(108616004)(120916001)(97736003)(50986999)(101416001)(4396001)(86362001)(92566001)(24736002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB176;H:BY2PR03MB175.namprd03.prod.outlook.com;FPR:;MLV:sfv;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-SW-Source: 2014-10/txt/msg00095.txt.bz2 PiBJJ20gZ2l2aW5nIHRoZSBnZGIvcmVnZm9ybWF0cy8gZGlyIHNvbWUgVExD IHRvZGF5LCBhbmQgd2hpbGUNCj4gcmVnZW5lcmF0aW5nIHRoZSAuZGF0IGZp bGVzIHN0dW1ibGVkIG9uIHRoaXMuDQo+IA0KPiBJJ3ZlIG5vdyByZXZlcnRl ZCB0aGUgcGF0Y2ggZnJvbSBtYWlubGluZSBhbmQgdGhlIDcuOCBicmFuY2gs IHdpdGgNCj4gdGhlIHBhdGNoIGJlbG93Lg0KPiANCj4gQ2F0YWxpbiwgY2Fu IEkgZ2V0IHlvdSB0byBmaWxlIGEgUFIgZm9yIHRoZSBmbG9hdGluZyBwb2lu dCBpc3N1ZSwNCj4gYW5kIGFkZCBpdCB0bzoNCj4gDQo+ICBodHRwczovL3Nv dXJjZXdhcmUub3JnL2dkYi93aWtpL0dEQl83LjhfUmVsZWFzZQ0KPiANCj4g Pw0KPiANCj4gKHRoYXQgUFIgbGlzdCBpcyB3aGF0IGdvZXMgaW50byB0aGUg Ny44LjEgcmVsZWFzZSBhbm5vdW5jZW1lbnQuKQ0KPiANCj4gVGhhbmtzLg0K W0NhdGFsaW4gVWRtYV0gDQpIaSwNCkkgZmlsbGVkIGEgUFIgZm9yIHRoaXMg aXNzdWU6DQpodHRwczovL3NvdXJjZXdhcmUub3JnL2J1Z3ppbGxhL3Nob3df YnVnLmNnaT9pZD0xNzQ1Nw0KDQpSZWdhcmRzLA0KQ2F0YWxpbg0K >From gdb-patches-return-116420-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Oct 06 10:02:05 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 25084 invoked by alias); 6 Oct 2014 10:02:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25069 invoked by uid 89); 6 Oct 2014 10:02:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Oct 2014 10:02:02 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id BAF069B28ECFD; Mon, 6 Oct 2014 11:01:57 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 6 Oct 2014 11:01:59 +0100 Received: from [192.168.154.101] (192.168.154.101) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 6 Oct 2014 11:01:58 +0100 Message-ID: <54326896.5070900@imgtec.com> Date: Mon, 06 Oct 2014 10:02:00 -0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: "Maciej W. Rozycki" , Pedro Alves CC: Subject: Re: [PATCH] MIPS: Ignore invalid regs during info registers all References: <1412088186-26402-1-git-send-email-james.hogan@imgtec.com> <542AC5A9.7060101@redhat.com> <542AC6CE.3070700@imgtec.com> <542ACDDB.2080202@redhat.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00096.txt.bz2 Content-length: 1245 Hi Maciej, On 03/10/14 17:32, Maciej W. Rozycki wrote: > On Tue, 30 Sep 2014, Pedro Alves wrote: > >>>>> The "info registers all" command causes mips_print_registers_info () to be >>>>> called for all register numbers, including invalid ones such as unused DSP >>>>> register numbers. This triggers an error () call which prevents further >>>>> register values being printed. Just silently return without printing >>>>> anything or erroring, so that all valid registers can be printed. >>>> >>>> What happens when the user does "info registers that-unused-register" ? >>> >>> I don't think that's possible, because the check is: >>> if (*(gdbarch_register_name (gdbarch, regnum)) == '\0') >>> >>> So any such register already has no name by which to refer to it. >> >> Indeed. :-) I'll leave it to Maciej to approve. > > I didn't know `info registers' (and `info all-registers' presumably as > well) supported further arguments; I'll experiment with the patch a bit > and see what comes out. > > James, did you push your change through regression testing? If so, then > how? Please always state precisely how changes you submit have been > validated. No I didn't. I'll get myself set up for running the test suite. Cheers James