From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G+o2ODruOWoDOxQAWB0awg (envelope-from ) for ; Mon, 22 Jun 2026 22:23:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1782181434; bh=bBjHYLSi3bUNNQ3nOrZcl4DNu9HpJh+rER0IvXQ0Z2Y=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=APKEraoMRlAypg5AZ59dtVK8+q+d1dcoLJ78Ido7O5pmyG49WiTylcCQdXhSrrrDq HpEgb19cEm14wB3UBN66W+l9dYZb0GYtwSzBvVWx20ximpRXg/3HaXQvey4eeyfmWh M/kEoBwqFRaRydNVmRx1ozl1kCC2IuWoH3erFQbQ= Received: by simark.ca (Postfix, from userid 112) id D5B151E070; Mon, 22 Jun 2026 22:23:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=pWw4thy4; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8173F1E070 for ; Mon, 22 Jun 2026 22:23:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 17DDA4BA2E1E for ; Tue, 23 Jun 2026 02:23:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17DDA4BA2E1E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=pWw4thy4 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DA9CD4BA2E0F for ; Tue, 23 Jun 2026 02:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA9CD4BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA9CD4BA2E0F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782181410; cv=none; b=wMqGc3pDjhgePiubTqefBfoU/xXR9gUr+ms2j/huOjKBiJEosCcEE6y3jOZt855saPimpTaD28a93yFh1ciSOaD3Asj/bh6tZXH3HzByDwI3WsnYebc/5Vu/oCNVGEi03/wL7CD3NbUh/973dzrTRw2wyyyBwiDOqlklchSGZns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782181410; c=relaxed/simple; bh=bBjHYLSi3bUNNQ3nOrZcl4DNu9HpJh+rER0IvXQ0Z2Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=mJZjb2KrA3kmpoJjZ9J9ksrzI89soSY9Knf6M6Z9uocKoNuJIv/nMBegY3ZtEBtWB3nVUw7H4g7rYtRvaUf11a72JzD3N2CaowkT1FWEptFkSp9czjWBXpOsDb8/wSd7AcHH3okfpUP7QHJ78RKOusjbQeHdZy5KvJcc4g2psPs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=pWw4thy4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA9CD4BA2E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1782181409; bh=bBjHYLSi3bUNNQ3nOrZcl4DNu9HpJh+rER0IvXQ0Z2Y=; h=Date:Subject:To:References:From:In-Reply-To:From; b=pWw4thy434Pf29tXkOKQa1PSSObfrewoo9neUamepYUpHfwr/RpZGqksBbDxEMMp3 LeGfJLCDjQSQDXhbDlnMKE5eAdobVEAqFrsHrykd2l2SsOqL7TS4225ys5S1FLd0Gc iEcmlKII0cnjExc5neXqDkD7dHIFhCH0unl7838c= Received: by simark.ca (Postfix) id 8A3AB1E070; Mon, 22 Jun 2026 22:23:29 -0400 (EDT) Message-ID: <5da0dcef-b250-4c06-b97c-e288e1c28e11@simark.ca> Date: Mon, 22 Jun 2026 22:23:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 2/2] gdb: convert sentinel_frame to a frame_info_ptr To: Andrew Burgess , gdb-patches@sourceware.org References: <75107040e4b5cdaa04f7e954d36d36857cbc8318.1782163808.git.aburgess@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <75107040e4b5cdaa04f7e954d36d36857cbc8318.1782163808.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/22/26 5:33 PM, Andrew Burgess wrote: > @@ -1726,12 +1763,12 @@ get_current_frame (void) > if (get_traceframe_number () < 0) > validate_registers_access (); > > - if (sentinel_frame == NULL) > - sentinel_frame = > - create_sentinel_frame (current_program_space, > - current_inferior ()->aspace.get (), > - get_thread_regcache (inferior_thread ()), > - 0, 0).get (); > + if (sentinel_frame == nullptr) While this works, in the previous patch you have used ".is_null ()". I'm pointing it out in case you want to change it, but otherwise it doesn't bother me too much. Otherwise LGTM. Approved-By: Simon Marchi Simon