From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94760 invoked by alias); 17 Jul 2017 19:34:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94696 invoked by uid 89); 17 Jul 2017 19:34:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:759 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 19:34:00 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9752C61BAC for ; Mon, 17 Jul 2017 19:33:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9752C61BAC Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9752C61BAC Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECFD318019; Mon, 17 Jul 2017 19:33:58 +0000 (UTC) Subject: Re: [PATCH 17/40] Linespec lexing and C++ operators To: Keith Seitz , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-18-git-send-email-palves@redhat.com> <59693B8B.6030205@redhat.com> From: Pedro Alves Message-ID: <5d602872-3a98-52a7-13a6-7650595a4d48@redhat.com> Date: Mon, 17 Jul 2017 19:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <59693B8B.6030205@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00235.txt.bz2 On 07/14/2017 10:45 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: >> >> (gdb) b -function operator<(int, int) -labe[TAB] # nothing happens >> >> gdb incorrectly thinks "-labe" is part of the "unclosed" template >> parameter list started with "<". > > Ouch. The best laid plans... :-) >> + p--; >> + if (p - start >= CP_OPERATOR_LEN) >> + { >> + p-= CP_OPERATOR_LEN; > > This is a cut-n-paste-o (that's a typo propagated via cut-n-paste). Missing a space before the operator. Whoops. >> + LS_TOKEN_STOKEN (token).ptr = start; >> + LS_TOKEN_STOKEN (token).length = PARSER_STREAM (parser) - start; > > Line length > 80? Indeed. Pushed with the obvious fixes. Thanks, Pedro Alves