Re: [PATCH 3/3] GDBserver self tests

Pedro Alves
2017-08-11T17:10:00Z

On 08/11/2017 04:30 PM, Yao Qi wrote:
>
> 2017-05-26 Yao Qi <yao.qi@linaro.org>
>
> * gdb.server/unittest.exp: New.

This is missing from the patch.

> +* New features in the GDB remote stub, GDBserver
> +
> + ** New "--selftest" command line option runs some GDBserver self
> + tests. These self tests are disabled in release.

"disabled in release mode." or "disabled in releases." ?

> @@ -3357,6 +3359,7 @@ gdbserver_usage (FILE *stream)
> " Options:\n"
> " vCont, Tthread, qC, qfThreadInfo and \n"
> " threads (disable all threading packets).\n"
> + " --selftest Run self tests.\n"
> "\n"
> "For more information, consult the GDB manual (available as on-line \n"
> "info or a printed manual).\n");

I wonder whether "gdbserver --help" should really advertise --selftests,
given it's a maintenance command and essentially does nothing in
release mode.

> +@cindex @option{--selftest}
> +The @option{--wrapper} option runs the self tests in @code{gdbserver}:
> +

Pasto: "--wrapper" should be "--selftest".

Thanks,
Pedro Alves