From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51656 invoked by alias); 11 Aug 2017 17:11:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51641 invoked by uid 89); 11 Aug 2017 17:11:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1511 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Aug 2017 17:11:10 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95594400F1; Fri, 11 Aug 2017 17:11:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 95594400F1 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2BC8A64BE; Fri, 11 Aug 2017 17:11:08 +0000 (UTC) Subject: Re: [PATCH 0/3] Use selftest.c in GDBserver To: Yao Qi , gdb-patches@sourceware.org References: <1502465408-24668-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <5d074f53-2f39-4e87-ee48-c035aa2b81a3@redhat.com> Date: Fri, 11 Aug 2017 17:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1502465408-24668-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00252.txt.bz2 On 08/11/2017 04:30 PM, Yao Qi wrote: > This patch series is split from "[PATCH 00/26 v3] Make GDB builtin > target descriptions more flexible" > https://sourceware.org/ml/gdb-patches/2017-07/msg00076.html, because, > IMO, adding self/unit tests in GDBserver doesn't related much to my > target description patches. My target description patches only use > common/selftest.c to do some unit tests in GDBserver. > > I also want to include one patch to use self tests in GDBserver, but > can't find a module in GDBserver to test. Nice, I had skimmed version of the patches in the large series a couple weeks back, and was planning on suggesting to move the gdb-specifics to hooks implemented by the client. Which is exactly what you've done. Moving to selftests namespace seems like a good idea to me too. I guess you could have left QUIT in the gdb hook, though it's fine with me to remove it. I wonder whether "gdbserver --help" should really advertise --selftests, given it's a maintenance command and essentially does nothing in release mode. Implementing gdb's version of "selftest::reset ()" in selftest-arch.c directly feels a bit like an abstraction violation. The cleanest would I guess be to add a new .c file with reset() that calls a new selftest-arch.c:reset_arch(), but we can always do that later if we need to reset other things. Otherwise, LGTM. Actually, I sent a couple comments to patch #3 now. But it's all minor things. Thanks, Pedro Alves