Re: [PATCH v8] This commit adds record full support for rv64gc instruction set

Guinevere Larsen
2025-04-23T14:14:17Z

On 4/23/25 11:01 AM, Aktemur, Tankut Baris wrote:
> On Wednesday, April 23, 2025 2:14 PM, Guinevere Larsen wrote:
>> Hi! Sorry for the delay, I'm applying and fixing merge conflicts, and
>> will be pushing this patch soon!
>>
>> If you plan on continue to develop GDB, you may want to get in contact
>> with Tom Tromey to setup write-after-approval access, so you are able to
>> push your own patches :)
>>
>> --
>> Cheers,
>> Guinevere Larsen
>> She/Her/Hers
>>
>> On 4/22/25 2:36 PM, Timur Golubovich wrote:
>>> Hi!
>>> Sorry to bother, but It seems like no one else has any questions about
>>> this patch.
>>> Maybe then it's possible to merge it?
> Hello Guinevere, Timur,
>
> With this patch, I started getting
>
> /usr/bin/ld: riscv-linux-tdep.o: in function `riscv_linux_syscall_record(regcache*, unsigned long)':
> /user/taktemur/gdb/gdb/riscv-linux-tdep.c:230: undefined reference to `riscv64_canonicalize_syscall(int)'
>
> I had configured GDB with --enable-targets=all.
Oh, oops. the riscv-canonicalize-syscall.c file hasn't been added to the
makefile, so all targets fails. I'm fixing this and the other build
issue (a commit from Tromey slightly changing one gdb syscall name) and
pushing the fix asap

--
Cheers,
Guinevere Larsen
She/Her/Hers