Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, vapier@gentoo.org
Subject: Re: [PATCH 1/2] sim/opcodes: Allow use of out of tree cgen source directory
Date: Tue, 27 Nov 2018 20:03:00 -0000	[thread overview]
Message-ID: <5cf23800-dc4b-e85e-8925-28c8648e4d66@FreeBSD.org> (raw)
In-Reply-To: <6f1e8a0d0901e5c97842fc153f992d3a@polymtl.ca>

On 11/27/18 11:47 AM, Simon Marchi wrote:
> On 2018-11-27 06:21, Andrew Burgess wrote:
>> Not as far as I can tell.  I left it in just in case, but as far as I
>> can tell there's no way to "install" CGEN.  I'd be happy to drop the
>> ../lib/cgen references (the else block) completely, and then validate
>> that we have a CGEN source tree or error.... But the above seemed like
>> the least invasive change.
> 
>  From what I understand from you description, there's no way it could 
> have been useful... but again, it's not hard to leave it there just to 
> be safe.  It's not my decision anyway :).
> 
> By the way, maybe this should still be sent to binutils for the opcodes 
> part?

My vote would actually be to remove it if it isn't really useful.  If
someone really needs it in the future they can always dig it out of the
history.

-- 
John Baldwin

                                                                            


  reply	other threads:[~2018-11-27 20:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 17:35 [PATCH 0/2] Allow use of out-of-tree CGEN source Andrew Burgess
2018-11-06 17:35 ` [PATCH 1/2] sim/opcodes: Allow use of out of tree cgen source directory Andrew Burgess
2018-11-26 21:07   ` Simon Marchi
2018-11-27 11:21     ` Andrew Burgess
2018-11-27 19:47       ` Simon Marchi
2018-11-27 20:03         ` John Baldwin [this message]
2018-11-29 19:01           ` Tom Tromey
2018-11-27 20:27         ` Andrew Burgess
2018-11-27 20:31           ` Simon Marchi
2018-11-30 19:07   ` Andrew Burgess
2018-11-30 19:50     ` Tom Tromey
2018-11-06 17:35 ` [PATCH 2/2] sim/cris: Fix references to cgen cpu directory Andrew Burgess
2018-11-30 19:51   ` Tom Tromey
2018-11-26 15:17 ` [PATCH 0/2] Allow use of out-of-tree CGEN source Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cf23800-dc4b-e85e-8925-28c8648e4d66@FreeBSD.org \
    --to=jhb@freebsd.org \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox