From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12349 invoked by alias); 14 Jun 2018 10:55:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12340 invoked by uid 89); 14 Jun 2018 10:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=hunk X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 10:55:19 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 22883857A4; Thu, 14 Jun 2018 10:55:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CBC81117628; Thu, 14 Jun 2018 10:55:17 +0000 (UTC) Subject: Re: [PATCH v2][PR cli/22573] Honour 'print pretty' when printing result of finish command To: Tom de Vries References: <20180609170752.2s4kdlyhat5d5bnn@localhost.localdomain> <4504da7f-593e-c8af-8ac9-40930cf9ce11@redhat.com> <20180614094758.ipkygcmpxdjpmfsj@localhost.localdomain> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5cd6f7f2-3425-4c77-b2eb-a9530256519e@redhat.com> Date: Thu, 14 Jun 2018 10:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180614094758.ipkygcmpxdjpmfsj@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00354.txt.bz2 On 06/14/2018 10:47 AM, Tom de Vries wrote: > Indeed. For gcc I've been using a pre-commit script ( > https://github.com/vries/bin-scripts/blob/master/git-prepare-gnu-commit.sh ) > that: > - updates the date in the log message > - copies all ChangeLog hunks to the appropriate ChangeLog files, prefixing > each hunk with the date/author line and the PR line > > So, the log message is not explicit about which files the ChangeLog hunks are > meant for, but the script makes sure they end up where they should. I see. FYI, most folks here follow the convention at ("In your patch email (...)"). > [ FWIW, I've just found GDBTestcaseCookbook on the wiki, and saw that > template.exp uses untested instead of fail in such a situation, I'm not sure > how relevant the difference is. ] Not much. >> Please resend a v2 with the issue addressed, and it should be >> ready to go. > > [gdb/cli] Honour 'print pretty' when printing result of finish command OK with the typo below fixed. Please make sure the git commit log includes the rationale [1], and push. > > 2018-06-08 Tom de Vries > > PR cli/22573 > * infcmd.c (print_return_value_1): Use get_user_print_options instead of > get_no_prettyformat_print_options. > > * gdb.base/finish-pretty.c: New test. > * gdb.base/finish-pretty.exp: New file. > + > +# Check whether finish respect the print pretty user setting when printing the > +# function result. "respect" -> "respects" Thanks, Pedro Alves [1] - sorry to be a nag, but your previous push did not include it. :-)