From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102326 invoked by alias); 27 Apr 2018 18:47:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102310 invoked by uid 89); 27 Apr 2018 18:47:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=literally X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Apr 2018 18:47:42 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E28344025F12; Fri, 27 Apr 2018 18:47:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CDD010F1BE0; Fri, 27 Apr 2018 18:47:40 +0000 (UTC) Subject: Re: [RFA v2 4/6] Expose type alignment on gdb.Type To: Tom Tromey , gdb-patches@sourceware.org References: <20180427140139.7957-1-tom@tromey.com> <20180427140139.7957-5-tom@tromey.com> From: Pedro Alves Message-ID: <5cbdf38e-014f-f597-a9db-7779f4babd56@redhat.com> Date: Fri, 27 Apr 2018 18:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180427140139.7957-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00577.txt.bz2 On 04/27/2018 03:01 PM, Tom Tromey wrote: > static struct type * > typy_lookup_typename (const char *type_name, const struct block *block) > { > @@ -1410,6 +1432,8 @@ gdbpy_initialize_types (void) > > static gdb_PyGetSetDef type_object_getset[] = > { > + { "align", typy_get_align, NULL, > + "The alignment of this type, in bytes.", NULL }, > { "code", typy_get_code, NULL, > "The code for this type.", NULL }, > { "name", typy_get_name, NULL, I thought it a bit odd to call the field "align" (a verb), so I went to look what we call the "size" field, thinking that if it were called literally "size", then "align" would be somewhat consistent (I would then read "align" as shorthand for "alignment"). But, what I found was that we call the size field "sizeof". So I think it would be more consistent to call the alignment field "alignof" instead. Agree? Otherwise looks fine to me. Thanks, Pedro Alves