Re: [PATCH v2 1/4] Add an optional offset option to the "symbol-file" command

Simon Marchi
2018-06-26T02:02:17Z

On 2018-06-11 08:08, Petr Tesarik wrote:
> If the main file is relocated at runtime, all symbols are offset by
> a fixed amount. Let the user specify this offset when loading a
> symbol file.
>
> gdb/ChangeLog:
> 2018-06-11 Petr Tesarik <ptesarik@suse.com>
>
> * symfile.c (symbol_file_command, symbol_file_add_main_1)
> (_initialize_symfile): Add option "-o" to symbol-file to add an
> offset to each section of the symbol file.
>
> gdb/doc/ChangeLog:
> 2018-06-08 Petr Tesarik <ptesarik@suse.com>
>
> * gdb.texinfo (Files): Document "symbol-file -o offset".
>
> gdb/testsuite/ChangeLog:
> 2018-06-11 Petr Tesarik <ptesarik@suse.com>
>
> * gdb.base/relocate.exp: Add test for "symbol-file -o ".

LGTM.

Simon