Re: [RFA 2/5] Use scoped_switch_auto_to_sym_language in symtab.c to switch language.

[Pedro Alves <palves@redhat.com>]

On 10/28/2018 02:46 PM, Philippe Waroquiers wrote:
> Use scoped_switch_auto_to_sym_language in treg_matches_sym_type_name to
> replace the local logic that was doing the same as the new class
> scoped_switch_auto_to_sym_language.
> 
> Use scoped_switch_auto_to_sym_language inside print_symbol_info, so
> that symbol information is printed in the symbol language when
> language mode is auto.
> This modifies the behaviour of the test dw2-case-insensitive.exp,
> as the function FUNC_lang is now printed with the Fortran syntax
> (as declared in the .S file).
> 

> +
>  
>    if (symbol_lookup_debug > 1)
>      {
> @@ -4601,6 +4598,7 @@ print_symbol_info (enum search_domain kind,
>  		   struct symbol *sym,
>  		   int block, const char *last)
>  {
> +  scoped_switch_auto_to_sym_language l (sym);

Sounds unnecessarily inefficient to use the scoped switch here
instead of at the caller to avoid the back and forth for each
symbol, but probably this isn't in any hot path, so it's fine.

>    struct symtab *s = symbol_symtab (sym);
>  
>    if (last != NULL)
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.exp b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.exp
> index b15dcafa00..2e3397865a 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.exp
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.exp
> @@ -42,8 +42,10 @@ gdb_test "info functions fUnC_lang" \
>  gdb_test "set case-sensitive off" {warning: the current case sensitivity setting does not match the language\.}
>  
>  # The dot-leading symbol is for ppc64 function descriptors.
> +# Note that info functions gives the FUNC_lang result using the fortran syntax
> +# as specific in dw-case-insensitive-debug.S DW_AT_language.
>  gdb_test "info functions fUnC_lang" \
> -	 "All functions matching regular expression \"fUnC_lang\":\[\r\n\]+File file1.txt:\r\n\tfoo FUNC_lang\\(void\\);(\r\n\r\nNon-debugging symbols:\r\n0x\[0-9a-f\]+ +\\.FUNC_lang)?" \
> +	 "All functions matching regular expression \"fUnC_lang\":\[\r\n\]+File file1.txt:\r\n\tfoo FUNC_lang\\(\\);(\r\n\r\nNon-debugging symbols:\r\n0x\[0-9a-f\]+ +\\.FUNC_lang)?" \
>  	 "regexp case-sensitive off"

OOC, the actual name & type matching respect the symbol's language, right?

Patch is OK.

Thanks,
Pedro Alves