From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id C5F023870876 for ; Tue, 8 Sep 2020 09:55:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C5F023870876 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 95090ADD5; Tue, 8 Sep 2020 09:55:24 +0000 (UTC) Subject: [committed][gdb/testsuite] Fix gdb.dwarf2/frame-inlined-in-outer-frame.exp To: Simon Marchi , gdb-patches@sourceware.org Cc: Scott.Linder@amd.com, Zoran.Zaric@amd.com References: <20200827205724.409603-1-simon.marchi@polymtl.ca> <20200827205724.409603-4-simon.marchi@polymtl.ca> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <5c2950c4-06a5-5ff8-6bf9-a329469d49e6@suse.de> Date: Tue, 8 Sep 2020 11:55:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827205724.409603-4-simon.marchi@polymtl.ca> Content-Type: multipart/mixed; boundary="------------7C0CE9D5286E3C68C67A1E8B" Content-Language: en-US X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2020 09:55:26 -0000 This is a multi-part message in MIME format. --------------7C0CE9D5286E3C68C67A1E8B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit [ was: Re: [PATCH v2 3/3] gdb: support frames inlined into the outer frame ] On 8/27/20 10:57 PM, Simon Marchi via Gdb-patches wrote: > +clean_restart $binfile > + > +if { [gdb_starti_cmd] != 0 } { > + fail "failed to run to first instruction" > + return > +} > + > +gdb_test "frame" "in _start .*" > + > +gdb_test "stepi" "in foo .*" "step into foo" Patch below committed. Thanks, - Tom --------------7C0CE9D5286E3C68C67A1E8B Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Fix-gdb.dwarf2-frame-inlined-in-outer-frame.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Fix-gdb.dwarf2-frame-inlined-in-outer-fra"; filename*1="me.exp.patch" [gdb/testsuite] Fix gdb.dwarf2/frame-inlined-in-outer-frame.exp I'm running into the following FAIL: ... (gdb) starti ^M Starting program: frame-inlined-in-outer-frame frame^M ^M ^M Program stopped.^M 0x0000000000401000 in _start ()^M (gdb) PASS: gdb.dwarf2/frame-inlined-in-outer-frame.exp: frame frame^M (gdb) FAIL: gdb.dwarf2/frame-inlined-in-outer-frame.exp: step into foo stepi^M 0x0000000000401001 in foo ()^M ... The problem is that the .exp file issues a gdb_starti_cmd without consuming the resulting prompt. Consequently, the gdb_test issuing the frame command consumes that prompt, and things are out-of-sync from that point onwards. Fix this by consuming the gdb prompt after gdb_starti_cmd. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-09-08 Tom de Vries * gdb.dwarf2/frame-inlined-in-outer-frame.exp: Consume gdb prompt after gdb_starti_cmd. --- gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp b/gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp index 721b521e83..0ded2c0e76 100644 --- a/gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp +++ b/gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp @@ -105,6 +105,7 @@ if { [gdb_starti_cmd] != 0 } { fail "failed to run to first instruction" return } +gdb_test "" "Program stopped.*" "starti prompt" gdb_test "frame" "in _start .*" --------------7C0CE9D5286E3C68C67A1E8B--