From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126230 invoked by alias); 12 Jul 2019 13:35:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126222 invoked by uid 89); 12 Jul 2019 13:35:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*M:d597, HX-Languages-Length:780, H*UA:Macintosh X-HELO: mpv4-2015.case.edu Received: from mpv4-2015.CWRU.Edu (HELO mpv4-2015.case.edu) (129.22.103.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Jul 2019 13:35:49 +0000 Received: from mpv5-2015.CWRU.Edu (EHLO mpv5-2015.case.edu) ([129.22.103.234]) by mpv4-2015.case.edu (MOS 4.4.8-GA FastPath queued) with ESMTP id AYN33291; Fri, 12 Jul 2019 09:35:33 -0400 (EDT) Received: from caleb.INS.CWRU.Edu (EHLO caleb.ins.cwru.edu) ([129.22.8.211]) by mpv5-2015.case.edu (MOS 4.4.8-GA FastPath queued) with ESMTP id CUC00923 (AUTH cpr); Fri, 12 Jul 2019 09:35:32 -0400 (EDT) Reply-To: chet.ramey@case.edu Cc: chet.ramey@case.edu, gdb-patches@sourceware.org Subject: Re: [PING^3][PATCH][readline] Fix heap-buffer-overflow in update_line To: Tom Tromey , Tom de Vries References: <20190525112458.GA3838@delia> <24b69803-ed21-118f-f50b-b5f1b321ddea@suse.de> <40b0c874-9b8e-c6f5-ee3b-401ef0118d9b@suse.de> <87v9w89ucv.fsf@tromey.com> From: Chet Ramey Openpgp: preference=signencrypt Message-ID: <5c19b045-0f49-d95d-d597-5fc8a7128876@case.edu> Date: Fri, 12 Jul 2019 13:35:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87v9w89ucv.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Junkmail-PrAS-Raw: score=8/90, refid=2.7.2:2019.7.12.122117:17:8.317, ip=, rules=__HAS_REPLYTO, __HAS_CC_HDR, __MULTIPLE_RCPTS_CC_X2, __SUBJ_REPLY, __PHISH_SPEAR_SUBJ_PREDICATE, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __ANY_URI, __URI_WITH_PATH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __FORWARDED_MSG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODY_SIZE_700_799, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_P1, __MIME_TEXT_ONLY, __URI_NS, HTML_00_01, HTML_00_10, BODY_SIZE_5000_LESS, IN_REP_TO, MSG_THREAD, __FROM_DOMAIN_IN_RCPT, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138 X-SW-Source: 2019-07/txt/msg00348.txt.bz2 On 7/11/19 4:41 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Apologies for the delay on this. > > Tom> Ping^3. > >>>>> 2019-05-25 Tom de Vries >>>>> Chet Ramey >>>>> >>>>> PR cli/24514 >>>>> * readline/display.c (init_line_structures, rl_redisplay): Ensure >>>>> line_size is at least _rl_screenwidth + 1. > > I don't know this part of readline very well. However, if Chet approved > it and/or put it into upstream readline, then it is fine for gdb. I did. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/