From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 579 invoked by alias); 21 Jul 2017 19:43:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 561 invoked by uid 89); 21 Jul 2017 19:43:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jul 2017 19:43:26 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6LJhJ4c008874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Jul 2017 15:43:24 -0400 Received: by simark.ca (Postfix, from userid 112) id DA3F61E5B7; Fri, 21 Jul 2017 15:43:19 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 609FF1E5A6; Fri, 21 Jul 2017 15:43:18 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 21 Jul 2017 19:43:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org, sergiodj@redhat.com Subject: Re: [RFA v2 1/4] C++-ify break-catch-sig In-Reply-To: <20170719203225.6714-2-tom@tromey.com> References: <20170719203225.6714-1-tom@tromey.com> <20170719203225.6714-2-tom@tromey.com> Message-ID: <5c13acfc17d2143f731b4255f48ae21c@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 21 Jul 2017 19:43:20 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00320.txt.bz2 Hi Tom, Two nits, in addition to what Sergio already pointed out. > @@ -355,8 +314,8 @@ signal_catchpoint_explains_signal (struct > breakpoint *b, enum gdb_signal sig) > then internal signals like SIGTRAP are not caught. */ > > static void > -create_signal_catchpoint (int tempflag, VEC (gdb_signal_type) *filter, > - int catch_all) > +create_signal_catchpoint (int tempflag, std::vector > &&filter, > + bool catch_all) The documentation of this function would need updating. > { > struct signal_catchpoint *c; > struct gdbarch *gdbarch = get_current_arch (); > @@ -373,57 +332,50 @@ create_signal_catchpoint (int tempflag, VEC > (gdb_signal_type) *filter, > /* Splits the argument using space as delimiter. Returns an xmalloc'd > filter list, or NULL if no filtering is required. */ > > -static VEC (gdb_signal_type) * > -catch_signal_split_args (char *arg, int *catch_all) > +static std::vector > +catch_signal_split_args (char *arg, bool *catch_all) The documentation of this function too. Thanks, Simon