From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17163 invoked by alias); 4 Jan 2018 13:25:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17153 invoked by uid 89); 4 Jan 2018 13:25:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Expression X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jan 2018 13:25:16 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1CDBB87623; Thu, 4 Jan 2018 13:25:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 758CB66A18; Thu, 4 Jan 2018 13:25:14 +0000 (UTC) Subject: Re: [PATCH 1/3] Add gdb.ada/info_addr_mixed_case new testcase To: Joel Brobecker , gdb-patches@sourceware.org References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> <1515054953-81012-2-git-send-email-brobecker@adacore.com> From: Pedro Alves Message-ID: <5c1398c0-0b8a-f480-551c-d1c2c65daed8@redhat.com> Date: Thu, 04 Jan 2018 13:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1515054953-81012-2-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00057.txt.bz2 On 01/04/2018 08:35 AM, Joel Brobecker wrote: > This patch adds a new testcase to demonstrate a regression introduced by: > > commit b5ec771e60c1a0863e51eb491c85c674097e9e13 > Date: Wed Nov 8 14:22:32 2017 +0000 > Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching > > The purpose of the testcase is to verify that a user can use any > casing for an Ada symbol name passed to the "info address" command. > After the patch above was applied, GDB was no longer able to find > the symbol: > > (gdb) info address My_Table > No symbol "My_Table" in current context. The mixed-case aspect is actually a red herring here. Using lowercase doesn't work either: (gdb) info address my_table No symbol "my_table" in current context. I think the problem is instead that "info address" is doing a symbol_name_match_type::FULL match, but the symbol's full name is pck.my_table, which doesn't match. If you pass the fully-qualified name, then it work, regardless of casing: (gdb) info address pck.My_Table Symbol "pck.my_table" is static storage at address 0x6155e0. (gdb) info address pck.my_table Symbol "pck.my_table" is static storage at address 0x6155e0. (gdb) info address Pck.My_Table Symbol "pck.my_table" is static storage at address 0x6155e0. Ada mode wants symbol names in expressions to be looked up using wild matching, unlike other languages. To handle that I had added symbol_name_match_type::EXPRESSION: /* Expression matching. The same as FULL matching in most languages. The same as WILD matching in Ada. */ EXPRESSION, IIRC, this is mainly used in the completion paths. I think we'll need to make "info address" use it too, and possibly other commands that accept an expression as argument. Thanks, Pedro Alves