From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8yl3MaFE6miDcSkAWB0awg (envelope-from ) for ; Sat, 11 Oct 2025 07:50:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=cjiXUICu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BC7011E047; Sat, 11 Oct 2025 07:50:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 21CA11E047 for ; Sat, 11 Oct 2025 07:50:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 993973857B9E for ; Sat, 11 Oct 2025 11:50:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 993973857B9E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=cjiXUICu Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 0AA87385843F for ; Sat, 11 Oct 2025 11:50:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AA87385843F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0AA87385843F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760183422; cv=none; b=AzJBBGGZbAqrsyS/VPThdNCBpZ70yxoYgGir10HjUrZs7J11HltfdGvBDVXoaC4kyIqagI79Rl1X6thUd5tfjoN6GSO9pw2VDHeYChEfcotmxEFmpeSm/rBUtvJQ59ijXVd0gmRrimuQbkK/WTw7HeyeHkAU1PsNx1yRUbUo5ow= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760183422; c=relaxed/simple; bh=v0g7/PIuz2Fy+bnf17XJeRyz/tx6bgskmEebkV6EsVQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RN41J49wD7pMwnUcxZTDK3aMKa6owu65zjcfUxPPyZhOPFaTdzPQi4MsnD3F7DMJs6ME8L2krqGNK/DSFEq/hxWEX98zM17Do4FNOyVQEh+sQWMXFCKnsMZnuXYNyzk33A/kxOYy7IS8Fl9EMCojEQVvEVPR95qYmbooRevXAeo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0AA87385843F Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-46e6c8bc46eso17386645e9.3 for ; Sat, 11 Oct 2025 04:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760183421; x=1760788221; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bLPx9uARCs+hgCSV6cXTsOFL9cQurbWbBFB7NR5oxsQ=; b=cjiXUICuGkEhGvtvFQK9W0aDjEAFVP9FJ/tZoUFksjuDhqiDOjFJtBaV+34fpsaxVt esK2KX/3RhZ9imgJ5d0xCPFmqWOYKz3mkqecOaH1/nSQEIWspLbzcqFYpX1pDm/UAx7W 8mTadMFjhlaZoHUxJvB3dALNLs4DzcXTQ3AhWyYhbR5pHvMvtZB4BwJPZ3VWqFGXLkxi DIYfCn77d6lDe9j5sHpC/T9DPooDDBhtsn8/9l5WQ4b6gg8GdOKB/D28RJQOhmVl/API +dTiaPScKe1Z5Kbcu8e0qiby+0qrMXKBEbRQkMgKm2diqYDutdsaMHvI8/EGh5XkVfyI 0ieg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760183421; x=1760788221; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bLPx9uARCs+hgCSV6cXTsOFL9cQurbWbBFB7NR5oxsQ=; b=GaXOjJ5FcerrE2nhIEcfAjpA35Xgf1r/eRkwKPDw8NMMBp45AoKyiHQ4v/bFayTWqC HPXebXW2KBVNFQLs1igCYowU+aKQ/NtWQLdLpM4eM2RZTs6jmSFwoDG96INnMQmL90eZ ow4YDsmBsHW3ZaGQVN3h00OA3zLx4GqwWNOTChfcqX9FvYdNGjrDbtiitossJlkik6xS tFAn5qRwJrftB7mKD3ALCPGEwGd3m+JnfTEf1PsWYsdh0ww8QYB7wnN1CIYRtGkhsif2 zV/uCNLqKiIJJ+m8Shy+CZdYks12Dwkecf7yZtkE8jbnGBPJpsvfJpEt+0A/mo5A1zz7 vbbw== X-Forwarded-Encrypted: i=1; AJvYcCWtUkWoI/MbpG6e9wocn0Ef1/ycagfW6qXUR6yVmWXrfDKuwbTrK42OwTAIIu2rE7vOaiqH7hU+ezwdsQ==@sourceware.org X-Gm-Message-State: AOJu0Yw3C4H8IrC2bSwgmQxeSET0yPB+yEeFNswa1D3f1JmB7EtVzaRC a9YI7pHhjyGB95jN5sO+sR4cbdeNjvie3Em5gDNaaTn8mm+N3dAfw3gLjANAFQ== X-Gm-Gg: ASbGncuZVlCuo3Tls0qsas+9OWJKzK9qzcCKOpH63ZNDJeykq0Iafyk5Rirdn1vIUYs 12KNTvmvuLw0D3N5Es64tJglt6rOaXCrIqg7ABedIknO2/1xPHhicDuSJ1QQ+Hf6ZPgAIhrKslf Au8sRkZ7tiNtsRAnvDD7NCTcuMpre66XJ8DAqXLczy9dNH5abl2lKKTPaKCoRg6wp8YqPreKfmC QpfzoErgNZp2k+3Rrr9E2rWF7LzcyFSPvCTLxR8WfFHpijoUA+Fn72ZOristKei1q/ztRI4+BTM UcstsWZdSxczNX3CNNaL9XwRn9kH6FRNYLbPG7FL7/oChglfdvDO6brTl6LuxvI1ikjga78bkay cMyrAdzwQYg7cw09B3Tyfm4e5PzDlfTH8tHXsdySRWYya2csTAJnOAagnWPOpa2bd X-Google-Smtp-Source: AGHT+IF4DcEHMBDEiaObBqMs62CDytjkPwVEPy4GPjChub3LOys0uYYnminutdmUci5NLaXoG53Z/g== X-Received: by 2002:a05:600c:3d8b:b0:45b:7ce0:fb98 with SMTP id 5b1f17b1804b1-46fa9a9456fmr96834295e9.5.1760183420625; Sat, 11 Oct 2025 04:50:20 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fc155143fsm13414115e9.11.2025.10.11.04.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Oct 2025 04:50:20 -0700 (PDT) Message-ID: <5bff9203-f0f8-4661-8aff-7b28d758416b@gmail.com> Date: Sat, 11 Oct 2025 12:50:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251007123132.26769-1-Ezra.Sitorus@arm.com> <20251007123132.26769-3-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20251007123132.26769-3-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Support FPMR in gdbserver. Nit. Make it "Add support for FPMR register set in gdbserver." It is a bit more descriptive. > --- > Changes from v1->v2: > * Updated comments > * Use HWCAP2_FPMR in aarch64_target::low_arch_setup > > Ezra > > gdbserver/linux-aarch64-low.cc | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc > index 9d3ac803e7b..73db8f52ed5 100644 > --- a/gdbserver/linux-aarch64-low.cc > +++ b/gdbserver/linux-aarch64-low.cc > @@ -248,6 +248,26 @@ aarch64_store_fpregset (struct regcache *regcache, const void *buf) > supply_register (regcache, AARCH64_FPCR_REGNUM, ®set->fpcr); > } > > +/* Fill BUF with the FPMR register from the regcache. */ > + > +static void > +aarch64_fill_fpmr_regset (struct regcache *regcache, void *buf) > +{ > + uint64_t *fpmr = (uint64_t *) buf; > + int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); > + collect_register (regcache, fpmr_regnum, fpmr); > +} > + > +/* Store the FPMR register to regcache. */ > + > +static void > +aarch64_store_fpmr_regset (struct regcache *regcache, const void *buf) > +{ > + uint64_t *fpmr = (uint64_t *) buf; > + int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); > + supply_register (regcache, fpmr_regnum, fpmr); > +} > + > /* Store the pauth registers to regcache. */ > > static void > @@ -879,6 +899,10 @@ static struct regset_info aarch64_regsets[] = > { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TAGGED_ADDR_CTRL, > 0, OPTIONAL_REGS, > aarch64_fill_mteregset, aarch64_store_mteregset }, > + /* Floating Point Mode Register (FPMR). */ > + { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_FPMR, > + 0, OPTIONAL_REGS, > + aarch64_fill_fpmr_regset, aarch64_store_fpmr_regset }, > /* TLS register. */ > { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TLS, > 0, OPTIONAL_REGS, > @@ -954,6 +978,10 @@ aarch64_adjust_register_sets (const struct aarch64_features &features) > if (features.gcs_linux) > regset->size = sizeof (user_gcs); > break; > + case NT_ARM_FPMR: > + if (features.fpmr) > + regset->size = sizeof (uint64_t); > + break; > default: > gdb_assert_not_reached ("Unknown register set found."); > } > @@ -986,6 +1014,7 @@ aarch64_target::low_arch_setup () > features.mte = linux_get_hwcap2 (pid, 8) & HWCAP2_MTE; > features.tls = aarch64_tls_register_count (tid); > features.gcs = features.gcs_linux = linux_get_hwcap (pid, 8) & HWCAP_GCS; > + features.fpmr = linux_get_hwcap2 (pid, 8) & HWCAP2_FPMR; > > /* Scalable Matrix Extension feature and size check. */ > if (linux_get_hwcap2 (pid, 8) & HWCAP2_SME) This one looks OK and should be fine to push once we have the rest of the series OK-ed Approved-By: Luis Machado