From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47584 invoked by alias); 4 Dec 2019 03:43:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47564 invoked by uid 89); 4 Dec 2019 03:43:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=speaking, HX-Languages-Length:855 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 03:43:30 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0AEED1E5F8; Tue, 3 Dec 2019 22:43:29 -0500 (EST) Subject: Re: [RFA] Implement 'print -raw-values' and 'set print raw-values on|off' To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190807193924.32268-1-philippe.waroquiers@skynet.be> From: Simon Marchi Message-ID: <5b8685bb-465e-ef47-1dc0-0746f489f4f8@simark.ca> Date: Wed, 04 Dec 2019 03:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20190807193924.32268-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00110.txt.bz2 On 2019-08-07 3:39 p.m., Philippe Waroquiers wrote: > The option framework documentation was speaking about a 'print -raw' > option, but this option does not exist. > > This patch implements -raw-values option that tells to ignore the > active pretty printers when printing a value. > As we already have -raw-frame-arguments, I thought -raw-values > was more clear, in particular to differentiate > set print raw-values and set print raw-frame-arguments. Hi Philippe, I'm just a bit worried about the naming, but I don't have anything better to suggest. I mention it in case you do. The "set print raw-values" sounds like superset of "set print raw-frame-arguments", because in my mind frame arguments are printed as values. Other than that, the patch looks fine to me. Simon