From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123577 invoked by alias); 25 Oct 2016 19:46:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123564 invoked by uid 89); 25 Oct 2016 19:46:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=1138, H*M:90ec, H*r:sk:18.2016, yours X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 19:46:08 +0000 Received: by mail-wm0-f68.google.com with SMTP id z194so113113wmd.5 for ; Tue, 25 Oct 2016 12:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=gEIcStHuznyAGZJrkF1I/rU9wKiNgn9eKP6F1z0vy8Y=; b=WiKroDN1byxhcFAw7itm8hoZ+GztmhLLbjFxzG0WrQ2Ppcvb1ucsT0xon9hIWVt5s6 TF+BYKL8dJwvNHm3Jo5xNf7JBHHI3JlDqw9iWiXfEFLqpqRtRq3sx2fAz0gMTKMX+KP5 iPOdCZbNlb9xcfPzwlJtLJPD/GBoSeokLbS1Wf1GUyttGXIiEK508U+o706tk81AQti7 5UeUSq9hJ8fgDO49kJhgUTx/xzysTElpxjr3u2W9WaLBptT5r/f8zXPVEClf0lvgjsEr UL1YQcBq6nhI6Y66cx7InjugKYE8v3lpxhCC0Fxq7uDhht+zKIOH537mVhynfBbn9SqF 4Q/A== X-Gm-Message-State: ABUngvf9V03YJySnBSpfJ8dORxjeDZX9qKeKZ5Ce7VzLJ67/Xq2/viKEpbUerp8fw8tY5g== X-Received: by 10.28.125.150 with SMTP id y144mr4986343wmc.77.1477424765809; Tue, 25 Oct 2016 12:46:05 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id k74sm5353927wmd.18.2016.10.25.12.46.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2016 12:46:04 -0700 (PDT) Subject: Re: [PATCH, v4] PR 20569, segv in follow_exec To: Luis Machado , gdb-patches@sourceware.org References: <1477415521-22010-1-git-send-email-lgustavo@codesourcery.com> <645baeb5-e813-d97d-fcd0-d0c7ea7bf5ba@redhat.com> <3f775c2e-6519-40c3-78da-7da06a940bce@codesourcery.com> <90c686ab-090e-fead-5a72-a5d507b50ab7@redhat.com> <3ecde577-fd7b-78ed-3d41-2777301cd390@codesourcery.com> <87c593b9-b811-d104-65fc-4225d46d5581@codesourcery.com> Cc: sandra@codesourcery.com From: Pedro Alves Message-ID: <5b758a61-90ec-19c3-d2db-7d88aec272f5@palves.net> Date: Tue, 25 Oct 2016 19:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87c593b9-b811-d104-65fc-4225d46d5581@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00712.txt.bz2 On 10/25/2016 08:41 PM, Luis Machado wrote: > Going back to the flags problem, maybe adding "add_flags" as argument to > symbol_file_add_main_1, just like symbol_file_add, and appending those > flags to the existing flag variable there would make things work? I've now cleaned up that patch, and simply rebasing yours on top shows what I meant: src/gdb/exec.c:184:59: error: could not convert ‘flags’ from ‘symfile_add_flags {aka enum_flags}’ to ‘objfile_flags {aka enum_flags}’ symbol_file_add_main_1 (exec_file_host, from_tty, flags); ^ Makefile:1138: recipe for target 'exec.o' failed I.e., the existing flags parameter to symbol_file_add_main_1 is _not_ a symfile_add_flags. We can't just use it as is. So yes, I think so. I was just doing that here, this minute. But I was replacing the from_tty parameter symbol_file_add_main with a symfile_add_flags instead. Let me do that and send both patches.