From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QY/xL4RM4mkl/R4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 11:06:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Uvt2CaB8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF6241E0B1; Fri, 17 Apr 2026 11:06:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 39AD21E093 for ; Fri, 17 Apr 2026 11:06:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B57E54AA396F for ; Fri, 17 Apr 2026 15:06:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B57E54AA396F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Uvt2CaB8 Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170110005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::5]) by sourceware.org (Postfix) with ESMTPS id 557C54C900C5 for ; Fri, 17 Apr 2026 15:06:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 557C54C900C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 557C54C900C5 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776438377; cv=pass; b=NwnQehcASYyKnoz20B/MtuP4CGVwqdLe4VC3tQI5U+bKNC4L7dzd8fD7D7uNKv5Gaq4D8Oh2pgbzy54YTl46nffRRXcpKqzqgXquS5kP/qk/jONS33KNjPxwwKMnv6F76wgeu9o4ULNhpnvtv+CK5VlIN6k073gx7bYmc1btuI0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776438377; c=relaxed/simple; bh=o19wF1g8QZ2QBzQif+0pviDi6J7nzljowclpTPs63iI=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=mIsU2WhRSKtufqKZiO2ha0ZS1mYArqt7ZWvYwX4n3yuJwHX9Tlm1ptInfrp5rsUNqXhsp0ZdBpf9Gl1fRXVlbbxGYsW64aeqSc9D8h22Zwx+P2C2DXFQ/h1ck2b32rkFA/NMmvqFVqJfznk3+NmNBRpcUDOJnOqGFuXGwUfvSDg= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 557C54C900C5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K3oU0dFsIEiTZ/vj7xemrPKSEYOWb6s4dNIk1Uj8wlvBy+67VYSyF9Di0N5QMNtgRXahUKGsMBifbsBUFvVdcggXFFDzs5Dk2DGaxs5OqbubxzkuH4+8iNH1ZHpP0pC+Uk9Qsgv7xdY1ApnKHTPD5p/Z0Bwt4z4kNd67lnDlH196JuQH3ncVSBxZjnms0xGMuymxIHaE9tkY6YSx1Visl9HlHScprg11PAhOXIctC6mGwPReylv+MTroMaN+AdCz6TCGSru1xBdoV31fVc3x8r/1jqXDhFgU/gfpR8FcCJMda2lvcR069TbWPfPCXzPrtq43OsvTr8xvp5oqByMF3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9j3Jj7rIDgLPCj0hzyiP6LCrpfuxoRvX2Dfnt7b+xHY=; b=SOW8knFFvt4dISkyV/exyLA9eNJeJ+eJGhu9O41ZTXO9nBP22ExiMePdG8VO7tgvAPqrKQKZ8cD/WsbplN4EhxQBU6NGCztMN4+QVtGkqq7n/e5IUoxSS3pN5Rad2a4jWrVtX4nfuhNSMNU++cUJD3hqdtlRxSMxjGHZvveBqzoHIsWFVGgbmE2NaXtOxAerXX4S21KtSKVq0Jh4J9r3v5YB4RUvlea+Yb8jUw8+UhfkQGZaOJ/OzNVI3nbZDVH23fmT05mUD0qw2ZcblKR6S2pG74IvY8Sh2Mg9Gu+lhZmg5Uaqke+Ta2eEJFJ2qoE3Q1zemQuCVsi4U9JvlTocEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9j3Jj7rIDgLPCj0hzyiP6LCrpfuxoRvX2Dfnt7b+xHY=; b=Uvt2CaB8QU4qCnG39vK+RRZCrDsxJNZIFpyf8/bOKBsaU36ZOREb8LOVY6Fw+gpRCtEObFl1EX5PhljlggzhWh2TMLND2StlBHDXuNjmDbbHLDjakAvCjmz+gfRe4jut4Nb6HxaqLXBRAksfyeZRtiXsQWLDPZzFjo5/c+qxcKbaiCWLQUGfmijkChkksuEjIk9uC+Nv490dLFMxdP+eKW9mmvvqNMMZvf0qtoKBMu61+XHu3aCReqAYP5w8Qt8kMZVsjQHyKJHmXh6alDxndfSQLetHoPrukJ/OZMgdt6P2ivHoQdFr0F4GzGOV1ONLnpAvIoQgFPViVSAjTEzGjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB9187.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr 2026 15:06:13 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9818.023; Fri, 17 Apr 2026 15:06:13 +0000 Message-ID: <5b6455b8-f800-4542-9143-9ec7af68bfbf@efficios.com> Date: Fri, 17 Apr 2026 11:06:11 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] gdb: make iterate_over_symbols return void, rename to for_each_symbol To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-12-simon.marchi@efficios.com> <87340tel7d.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87340tel7d.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0046.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2::18) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB9187:EE_ X-MS-Office365-Filtering-Correlation-Id: 6257b489-0381-4c3a-57c9-08de9c92dd87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: BhzYLsigs7cmk1S1BEOJUlxwN0Pexd5AlvH9aZLQDuT1d0jSEMv3ndyxKKJqo1qE838TDvWKTBwa+UN11fg3nSzMrnIRzxQzHVsX+St63ztlmFOqaLEW1xMEKs7lRi4qdcbitlgGa812S028jvxxEpPjuQBxujgJMXcaRNS5UDBVuY/lra0tkryNQnOfKUW7Q58IMsyHQCW7pjav/K/XY3GPY6/aw2+cdSlA43Eu6yYi5bz4yyJSUnj0eyKhdxTfCCPlhItPlNojJ/W3QcjXFO9LK1bZzwY+jojVBe1PReCPriT/K1WnnTcVzxLQJE+WFMzlsR+RbrcOFRXoOI9ujwN2t2wkl8il35p3WLlHVgxottjsn0h2n46ti6lURbA24BOIVAQUDpCBF5Cex3EmZp0vrRMpYsycJO/gMAJe5BYxPMfOd8ex23dx350hQd9ArXKGm2kZamD6wsnrD0WPjemqIFjW1IBrumnRPAxyJ3IGRaPSOSeocL/Chfnlfb0dAFCvsVbYOzega0k/Xklo4m5fFOKDM7oYDE0tTBKiTNkCip0aaocGxcq87yXDOPMRRoZ2oKF/2V7ma6yXnpZowgZSkf0h5ooMmUaVobX4n4ZEbTx4MQSYTdd+2xKzlzoB2zXFcnLSfmwTahyrpHSo9A2Ke76GrYJ11WOoWC8I29Z4xBu2wvaQvcwFKzJjq2fQHtDqNAlt2rCgfhJq5jHA1w9j9oaJyw0j+AAd9fihrL8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(56012099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGlyOTArRVFjYUdoR2hxNVZoTExmeUhhQU0rUjBuc1N0eGJ5YThkYzg2REtw?= =?utf-8?B?d1FiUFE1dXRSUGNQdXVJczlXeFNIVDdWMHkyY083SmZqaTU0QytqYkllYkMr?= =?utf-8?B?VE9tUlZ3a1laMmYrbW5HNVdaQnhoNFRPTXJzRmFsM0RIaThhYVJscmd5S1lw?= =?utf-8?B?R1hGMU5RT3hUL1JtZFQ2aVdJdno3U1kxL3FhellzSkdmL1RHMVYzeEpNaGxw?= =?utf-8?B?YzlURU9FME9iY0Q4aFhSVy9xYzlmZlN3UGNRV21mYmVrMU03Sm9PZ2dSY1JD?= =?utf-8?B?R1FQaEFsN2J6N05kUnptcEJDNU9LSnFhd1d5YTk4WFhCOXhoMzM4QzcxdVdy?= =?utf-8?B?QkZ5RVhWVHRGWDZEV3RUV09MeHdCbzRET3ZWUkhOczVqbXdseGg4MlR1ckc0?= =?utf-8?B?dCtMSUY1d0N0elp6cE41TUxsU0ppbUtiSVkvVlJpbGY4N2ZQc3h3SVFHL0lL?= =?utf-8?B?RUp4Q2tsTjBnZmtGa3p6K09qeDFKQWlwc0tpYlRiZURxUDVRMVJ0RlV5bEFL?= =?utf-8?B?U2czVjJtaGJ6SEFpajV3TUZwcGp2SWhqWHNVdk5XNVJWbW4wMnFpTmNmVmFV?= =?utf-8?B?M2RpbEFZQW5SZkdJSStqYjEwcXkwNWhrN1ZZblh5aTV1Z0xJb2YxYXRKQXkr?= =?utf-8?B?ZHI5aCt1RmhSdTd6UEsyQlNwWjdtbVB3K3hlcFp6Zk1lTzRBd0pJZXlLVEJi?= =?utf-8?B?SHl3VjlEeHExbGtnaFJUVXQzUU1aUy9LMmZZcFJHYkR4SE93WE91UkxaQldG?= =?utf-8?B?WE5vekJKemR1djU4T3JLTWpFM0lwTUtrWU00ZVVKV0VmOVBCaGJhYzV6T09o?= =?utf-8?B?REd4RlRna081eGlZL1NTdDFBcDFUWnIxdFZLSHRZQ0FhNXR5L3dCNktyVnNP?= =?utf-8?B?ZWNwb1gvZ0lFcUNYbWlLN3hQaXpHQlVWZnNmYzI3b1pSdGZhM0FGTEovWWV5?= =?utf-8?B?YkduY1MxempDUXdWdGZYdnRTSjJ6M0l2ZjZLbmJTbjJCWVNvWUQ2NEZaQ21j?= =?utf-8?B?SUUwV1RwYUk0N2Vrbm9DMFBGN2Jqa1U0d2lHZFpqY2g5Y3FCOS9lRTI5NjUv?= =?utf-8?B?K2VuM21ieEJCMUVOTFUyNXRFU0xhMjBzSGd5Nis2OGtDQ3M4NlBMT0NhTlFs?= =?utf-8?B?MzY3R0pDdTR4WXFGUTM1cXdJcDJIU0Y1NjhQTmpMOWRoajB4aGNkNnRjdXAw?= =?utf-8?B?bXU4MVQyUVUzaTczV3RleFF0eTlPRXdNUnA0Qks1TmhGVDRqcWt0ZlVGWTNS?= =?utf-8?B?MjR6d25SZW5WQTVnUXFuVGRqY0FoTG9NUWNXakhKZ09mMlpkR1FVTDZxUjkz?= =?utf-8?B?dGxTRFE4V2VYbk5yTFZJVi9oTWZVSjhmbkFuZzBWeVVZWmFiSlRnNmFQWm5R?= =?utf-8?B?aHZScnU5NldqR0ZudWFqVVNiczloTWVNTElGZW9sOVk0NWhBcUFsem9kUjFC?= =?utf-8?B?QW1Nd0VYYy9sOHVodWYxdnVjbzNaS0VMY2hrOWZadGd3WHlaOHhic1g4QTBX?= =?utf-8?B?ejJYU3RLZkFkemVkSmNoamowU3pMcU1FNEpGYkptZ1ZleWtBcDNyNjEvSUtP?= =?utf-8?B?V2p1NW1sTUwrV1lBY085ZnByYU82M1NKOHdCVE8rWTI4ajR4QlRMSEpreFdy?= =?utf-8?B?a0NyT3pYT0J2cDgxYXJscm9sSkNHSTYvWFNCZ2R2VzFuaTR5Wk5QNUErN2RR?= =?utf-8?B?em1YRmNhdDlWMlFLV3l5VDhncHU2WW1EZTFxUUM0dS9yOXFnQnBrYUxTeXk5?= =?utf-8?B?STFobWIzTWd4NU16N3RkMnRNOStzZ2JSb1pXRnhOeU9zQmMrR2lPenNxY1VJ?= =?utf-8?B?NTBWVmt4SWZ5S242Y0RScVVCRFVKU0dxV3c1NlpUTEVYWWh3L1BYOXJPd3pF?= =?utf-8?B?NmdMajdsb2oyc09ZSmxqVWFUK1BQT0JZR3dCVTBuMzZvZDIvMnJZTkN1ZjJ6?= =?utf-8?B?bkhBaDFGVFlQc3NtMUNjM3FUbkFXd0x6NThNaXkxMHBPZGRJN3M4cEFnRFY0?= =?utf-8?B?TDRXZ2RQZjhOY0FRUFVRdFhsSlMzVXVPdmlVNGw2NncraUFGbi81bnFBcng2?= =?utf-8?B?d0hjUzg2WkdpeE0ralBGVU1LYngzSkpnZjFXTEFDRGFTTzhnS001b0poTG5N?= =?utf-8?B?MFBLOVhid2IzYll2TkpUb1A1bjNDQ3lZRllBTE0rdy9TNzVGSUVVSDdVRHBD?= =?utf-8?B?VkJqeGFGazhBeEJiMDVoWkRDZ3NORmcxZHhtd005L0lGWWJJeTJoanlBOEcy?= =?utf-8?B?ZzIxc1RvNmNGTFJwd3daQ0ZFRDBiNmJESWRMakg5L0YvRVpuQVhiZTl4NzZG?= =?utf-8?B?cWJITkFBRWhXYnA3QjBiMW92TGduK2JiSWVWRUJCdU5BMkNsL3N3dz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6257b489-0381-4c3a-57c9-08de9c92dd87 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2026 15:06:13.0267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H2iyDD8ckFZUP63BjyH/bCYdTN2FssMCKqIg5v4uNG36QML82gPMXRPXRuls9xeNfcjvOeb7/Dh14l4C/Z5Vew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB9187 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 10:05 AM, Andrew Burgess wrote: > Simon Marchi writes: > >> From: Simon Marchi >> >> Nothing really uses the return value of iterate_over_symbols and >> language::iterate_over_symbols. Also, all provided callback always >> return true, iterating on all matching symbols. Simplify them to not >> return a value and not have the "stop iterating" feature. >> >> Rename to for_each_symbol, just to be consistent with previous patches. >> >> Also rename symbol_found_callback_ftype to >> for_each_symbol_callback_ftype for consistency. >> >> Change-Id: I55ff3162098bb069dc1de1afca10dd9abfc05c34 >> --- >> gdb/ada-lang.c | 26 ++++++++------------------ >> gdb/language.h | 13 ++++--------- >> gdb/linespec.c | 38 ++++++++++++++++---------------------- >> gdb/symtab.c | 23 +++++++++-------------- >> gdb/symtab.h | 22 +++++++--------------- >> 5 files changed, 44 insertions(+), 78 deletions(-) >> > >> @@ -5665,7 +5660,7 @@ ada_add_all_symbols (std::vector &result, >> else >> { >> /* In the !full_search case we're are being called by >> - iterate_over_symbols, and we don't want to search >> + for_each_symbol, and we don't want to search > > As you're touching this comment anyway, could you fix the first line > please, the 'are' is not necessary: > > In the !full_search case we're being called by ... Done. >> @@ -2806,26 +2806,18 @@ using find_symtab_callback_ftype = std::function; >> std::vector find_linetable_entries_for_symtab_line >> (struct symtab *symtab, int line, const linetable_entry **best_entry); >> >> -/* Prototype for callbacks for LA_ITERATE_OVER_SYMBOLS. The callback >> - is called once per matching symbol SYM. The callback should return >> - true to indicate that LA_ITERATE_OVER_SYMBOLS should continue >> - iterating, or false to indicate that the iteration should end. */ > > And again, I complained about this in the previous patch review, but > you've now removed it. So again, apologies. > > Approved-By: Andrew Burgess Thanks, Simon