From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/9] [gdb] Make gdb dir codespell-clean
Date: Mon, 15 Jun 2026 12:29:43 +0200 [thread overview]
Message-ID: <5b483313-ce44-4d35-8a1b-be925c5776f4@suse.de> (raw)
In-Reply-To: <20260603100516.144737-1-tdevries@suse.de>
On 6/3/26 12:05 PM, Tom de Vries wrote:
> This patch series make the gdb dir codespell-clean.
>
> It starts out with two unrelated patches:
> - the first fixes a problem found during review.
> - the second adds brief description lines in codespell-ignore-words.txt.
>
> A few following patches fix codespell errors, each in a different way.
>
> The pre-last patch adds the gdb dir to the pre-commit codespell check.
>
> The last patch move selection of files to check from .pre-commit-config.yaml
> to gdb/pyproject.toml.
>
With current trunk and this patch series, we get:
...
$ pre-commit run codespell --all-files
codespell................................................................Failed
- hook id: codespell
- exit code: 65
gdb/microblaze-linux-nat.c:97: Transfering ==> Transferring
$
...
Since the patch series is low-risk, I'm pushing this.
The only change I'm adding is this (and similar):
...
-The codespell:ignore-begin raison d'etre codespell:ignore-end of
+The <codespell:ignore-begin> raison d'etre <codespell:ignore-end> of
...
to make the sentence easier to read.
While re-reviewing this patch series, I've filed a PR to improve
codespell support for gdb (
https://sourceware.org/bugzilla/show_bug.cgi?id=34285 ).
Thanks,
- Tom
> Tom de Vries (9):
> [gdb] Drop executable mode in some files
> [gdb/contrib] Describe words in codespell-ignore-words.txt
> [gdb/contrib] Extend codespell-ignore-words.txt
> [gdb] Fix typos
> [gdb] Fix codespell false positives by ignoring
> [gdb] Fix codespell false positive by string splitting
> [gdb] Fix codespell false positives by renaming
> [pre-commit] Include gdb in codespell check
> [pre-commit] Simplify codespell configuration
>
> .pre-commit-config.yaml | 2 +-
> gdb/ada-lang.c | 4 +-
> gdb/amd64-tdep.c | 2 +-
> gdb/arc-linux-tdep.c | 4 +
> gdb/arm-linux-nat.c | 6 +-
> gdb/arm-tdep.c | 2 +-
> gdb/avr-tdep.c | 5 +-
> gdb/bfin-linux-tdep.c | 2 +-
> gdb/bfin-tdep.c | 2 +
> gdb/buildsym.c | 6 +-
> gdb/buildsym.h | 2 +-
> gdb/completer.c | 10 +-
> gdb/completer.h | 2 +-
> gdb/contrib/codespell-ignore-words.txt | 26 +++
> gdb/cp-support.c | 2 +-
> gdb/darwin-nat-info.c | 2 +-
> gdb/displaced-stepping.h | 2 +-
> gdb/gdbtypes.c | 16 +-
> gdb/i386-tdep.c | 170 +++++++++---------
> gdb/i387-tdep.c | 2 +
> gdb/infrun.c | 2 +-
> gdb/infrun.h | 2 +-
> gdb/loongarch-tdep.c | 2 +-
> gdb/mips-linux-nat.c | 2 +-
> gdb/mips-tdep.c | 2 +
> gdb/nds32-tdep.c | 2 +
> gdb/ppc-linux-nat.c | 4 +-
> gdb/ppc-linux-tdep.c | 8 +-
> gdb/printcmd.c | 6 +-
> gdb/pyproject.toml | 5 +-
> gdb/remote.c | 4 +-
> gdb/riscv-tdep.c | 2 +
> gdb/s390-linux-tdep.c | 2 +
> gdb/s390-tdep.c | 6 +
> gdb/ser-event.c | 14 +-
> gdb/source.c | 3 +-
> gdb/symtab.c | 4 +-
> gdb/testsuite/gdb.arch/amd64-lam.c | 0
> .../gdb.base/jump_multiple_objfiles-foo.c | 0
> .../gdb.base/jump_multiple_objfiles.c | 0
> .../gdb.base/jump_multiple_objfiles.exp | 0
> .../gdb.base/jump_multiple_objfiles.h | 0
> gdb/testsuite/gdb.btrace/exception.exp | 0
> gdb/testsuite/gdb.fortran/nested-funcs.exp | 0
> gdb/testsuite/gdb.fortran/nested-funcs.f90 | 0
> gdb/testsuite/gdb.fortran/oop_extend_type.exp | 0
> gdb/testsuite/gdb.fortran/oop_extend_type.f90 | 0
> gdb/testsuite/gdb.fortran/print_type.exp | 0
> gdb/testsuite/gdb.fortran/vla-type.exp | 0
> gdb/testsuite/gdb.fortran/vla-type.f90 | 0
> .../gdb.testsuite/gdb_test_multiple-lbl.gdb | 0
> gdb/testsuite/lib/compiler.cc | 0
> gdb/utils.c | 4 +-
> gdb/valprint.c | 8 +-
> gdb/value.c | 3 +-
> gdb/windows-nat.c | 12 +-
> gdb/windows-nat.h | 2 +-
> gdb/x86-windows-nat.c | 2 +
> gdb/xcoffread.c | 2 +-
> gdb/xtensa-tdep.c | 2 +-
> gdb/xtensa-xtregs.c | 2 +
> gdb/z80-tdep.c | 2 +-
> 62 files changed, 220 insertions(+), 158 deletions(-)
> mode change 100755 => 100644 gdb/amd64-tdep.c
> mode change 100755 => 100644 gdb/testsuite/gdb.arch/amd64-lam.c
> mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c
> mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles.c
> mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles.exp
> mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles.h
> mode change 100755 => 100644 gdb/testsuite/gdb.btrace/exception.exp
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/nested-funcs.exp
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/nested-funcs.f90
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/oop_extend_type.exp
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/oop_extend_type.f90
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/print_type.exp
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/vla-type.exp
> mode change 100755 => 100644 gdb/testsuite/gdb.fortran/vla-type.f90
> mode change 100755 => 100644 gdb/testsuite/gdb.testsuite/gdb_test_multiple-lbl.gdb
> mode change 100755 => 100644 gdb/testsuite/lib/compiler.cc
>
>
> base-commit: 22e21551bd7eb2fe14cdebfb4d89d51e5d93b7dd
prev parent reply other threads:[~2026-06-15 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 10:05 Tom de Vries
2026-06-03 10:05 ` [PATCH 1/9] [gdb] Drop executable mode in some files Tom de Vries
2026-06-04 20:05 ` Simon Marchi
2026-06-04 20:07 ` Tom de Vries
2026-06-03 10:05 ` [PATCH 2/9] [gdb/contrib] Describe words in codespell-ignore-words.txt Tom de Vries
2026-06-03 10:05 ` [PATCH 3/9] [gdb/contrib] Extend codespell-ignore-words.txt Tom de Vries
2026-06-03 10:05 ` [PATCH 4/9] [gdb] Fix typos Tom de Vries
2026-06-03 10:05 ` [PATCH 5/9] [gdb] Fix codespell false positives by ignoring Tom de Vries
2026-06-03 10:05 ` [PATCH 6/9] [gdb] Fix codespell false positive by string splitting Tom de Vries
2026-06-03 10:05 ` [PATCH 7/9] [gdb] Fix codespell false positives by renaming Tom de Vries
2026-06-03 10:05 ` [PATCH 8/9] [pre-commit] Include gdb in codespell check Tom de Vries
2026-06-03 10:05 ` [PATCH 9/9] [pre-commit] Simplify codespell configuration Tom de Vries
2026-06-15 11:16 ` Tom de Vries
2026-06-15 10:29 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b483313-ce44-4d35-8a1b-be925c5776f4@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox