From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128136 invoked by alias); 19 Sep 2019 11:04:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128097 invoked by uid 89); 19 Sep 2019 11:04:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2019 11:04:27 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 862A71E4B2; Thu, 19 Sep 2019 07:04:25 -0400 (EDT) Subject: Re: [PATCH] Move arm_apcs_32 extern declaration to header To: Christian Biesinger , gdb-patches@sourceware.org References: <20190919043533.45876-1-cbiesinger@google.com> From: Simon Marchi Message-ID: <5b3baa25-23aa-b2b3-ef4d-ab882d316582@simark.ca> Date: Thu, 19 Sep 2019 11:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190919043533.45876-1-cbiesinger@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00362.txt.bz2 On 2019-09-19 12:35 a.m., Christian Biesinger via gdb-patches wrote: > Instead of having several extern declarations for arm_apcs_32 > in a few .c files, declare it in arm-tdep.h. This file is already > included from these .c files. LGTM. If you want, you can also move the documentation of the variable to the .h and use /* See arm-tdep.h. */ in the .c. Simon