From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oSOdCFltpmlM0hEAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 00:10:49 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=CF81X9XX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1C61F1E0DD; Tue, 03 Mar 2026 00:10:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E9BE01E08D for ; Tue, 03 Mar 2026 00:10:47 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7DCDE4BA2E0D for ; Tue, 3 Mar 2026 05:10:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DCDE4BA2E0D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=CF81X9XX Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C53E14BA2E18 for ; Tue, 3 Mar 2026 05:10:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C53E14BA2E18 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C53E14BA2E18 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772514611; cv=none; b=TGZAYL/DkoAqK4EvMKEC6FKd378egyJgYVL5rsrLTWKNUtHvC644SJY8KROoZcCaxwtZw/UFIUdUfKttPyQxr7cO5kM9ZdlAYIh2iUhCvI5TJKFjKBUgDxPws3TD45sThNQHyYhmtLVQqbzewy82Z1MZX/UfLW9WnjdZyfcqgF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772514611; c=relaxed/simple; bh=wK7qH+/WnAcqc6gXx0xoFmZBo9KXIWlWUC+ByshOgRM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hl7uy0uBF6RZ/KTdGHeXw3eEsy1FFP1aFr4PmxN2B5/tzlILKuj0NKdYF0BqsfM5EIdiIYgndFR8APXH69ss8qsUMCSX4iE+NZaH+LwmeDJLogjyggVpgBnz4L7jwW349gQPDrJvJcdsPuYDPJB5TrLQ3gFZfBnZMLLF0yOKLQs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C53E14BA2E18 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6234ImK01850818; Tue, 3 Mar 2026 05:10:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=I1AzyveIZ6aYf77oLtLL7XhMicVTHj iUFLSwQJohlHQ=; b=CF81X9XX301XhXP+apaaunCeIwRb6sA9ebU6BG86tGKtX3 tb2/SUMF/a3EiodIaGLgygzsIiP3g2xzRIOyzqtsvVQoGK3CByrS9t1ThtZ4OJiM Y03Yz83xSJsldqIr2Kd4uRTEofPgT0QDd4/hCpxI0AASbXT8AptVHLZQZNEKsGgO I63fh5D9xW3AcdaxSd+GdJdo2NYxT0X8r0QOuozTrRdSjikDjSSYHDS0b6oZwMZU IqsaYTRCK85NffXZ6TDX/6fML68JmIqz9hfo4MDpB6j9Icxsg4VCZ6vraqk+pyEH SCY6umhUcxZv5iKmtIjsTuQalo4vXdRmGKlW78Ow== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ckskcsm3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Mar 2026 05:10:09 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 6234WWND016756; Tue, 3 Mar 2026 05:10:08 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4cmbpn0x3c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Mar 2026 05:10:08 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6235A7iC32375452 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Mar 2026 05:10:07 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD86058056; Tue, 3 Mar 2026 05:10:07 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CAFBD5803F; Tue, 3 Mar 2026 05:10:06 +0000 (GMT) Received: from [9.109.244.166] (unknown [9.109.244.166]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 3 Mar 2026 05:10:06 +0000 (GMT) Content-Type: multipart/alternative; boundary="------------dW0axZnxLibo0G7v7Zat5qTk" Message-ID: <5af9f5dc-c5ac-44ae-bdfe-41ff4c6c476a@linux.ibm.com> Date: Tue, 3 Mar 2026 10:40:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/record] Fix syscall recording some more To: Tom de Vries , gdb-patches@sourceware.org References: <20260226144529.360296-1-tdevries@suse.de> Content-Language: en-GB From: Abhay Kandpal In-Reply-To: <20260226144529.360296-1-tdevries@suse.de> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3lAH704byvtZGO3Kfda8ngCiPeC6YuvU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDAzMyBTYWx0ZWRfX0fDHtcHVANiW RWlwVuVxHRtRNA1GRLds7Az1pQe0XeoGqNrLbSd1t0QQxmNF3m9YcyR+m8c57nZZZm3yh4iXTfe IvLZvSw9pXWC70jyNYlyTBjHqK1j5ZGOPAhTADnKRIA6hqN4brM6vK4UFDvBml1yLbZ5Pr1uWAk WQ+kEVFKmXZhjNi0KyNUPGZzSm2SQCRkl4fzznskp3a1Qiye4GwRMT0qk7RdtkVaG8ZuaPNQ9VE DnBqsmR6H2nU24ud92uduXaWCpEJiI1jCZTFtosGj/ifG2zidXrVHYXSaHbWxtTNSBYviwmCqDX quZLP9km6+/ECRD80z4e+lQSF0wBBbf2hHvWiQtZfs6I+iow9XIo893K405ItMyEJkByTi/dsd3 YL2dokg+OOhhi3TjNbLP325meUxRSIEwTXRM6Rhxl/JklydFdxrU2ZE5xkqwTakXhr46jh1HoyD XNtuQZQUpZNZiad5ZIA== X-Authority-Analysis: v=2.4 cv=H7DWAuYi c=1 sm=1 tr=0 ts=69a66d31 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=r77TgQKjGQsHNAKrUKIA:9 a=VnNF1IyMAAAA:8 a=EKc3EMEzDZA8itzuEYwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=loOxy2AzxVunjCPMDHIA:9 a=nqKOv3x2dKtIlqvu:21 a=_W_S_7VecoQA:10 a=lqcHg5cX4UMA:10 X-Proofpoint-ORIG-GUID: 3lAH704byvtZGO3Kfda8ngCiPeC6YuvU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030033 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------dW0axZnxLibo0G7v7Zat5qTk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Tom, On 26/02/26 20:15, Tom de Vries wrote: > I ran into the same gdb.reverse/sigall-reverse.exp failure on ppc64le-linux, > as fixed in commits: > - commit 3686645cec9 ("[gdb/record] Fix return value for svc in > aarch64_record_branch_except_sys"), and > - commit 4ef576bdb7f ("[gdb/record] Fix return value for syscall in > loongarch_record_syscall_insn"). > > The difference with those commits is that the problem is not due to confusion > about a port-local enums (aarch64_record_result, loongarch_record_result). > > Instead, the port just treats return values 1 and -1 the same: > ... > if (tdep->ppc_syscall_record (regcache) != 0) > return -1; > ... > > Fix this by passing through the return value 1 instead. > > Likewise on s390x-linux. > > Tested on ppc64le-linux and s390x-linux. > --- > gdb/rs6000-tdep.c | 5 +++-- > gdb/s390-tdep.c | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index 8aa155e1f36..7d0902941a0 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -7187,8 +7187,9 @@ ppc_process_record (struct gdbarch *gdbarch, struct regcache *regcache, > > if (tdep->ppc_syscall_record != NULL) > { > - if (tdep->ppc_syscall_record (regcache) != 0) > - return -1; > + int res = tdep->ppc_syscall_record (regcache); > + if (res != 0) > + return res; > } > else > { I ran into the same issue on ppc64le and submitted a similar fix independently. I’ve tested your patch on Power10 (ppc64le), and it resolves the problem there as well. Please feel free to add: Reviewed-by: Abhay Kandpal Thanks for addressing this and for covering s390x as well. > diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c > index 6cf5acbc542..f52e898047b 100644 > --- a/gdb/s390-tdep.c > +++ b/gdb/s390-tdep.c > @@ -3242,8 +3242,9 @@ s390_process_record (struct gdbarch *gdbarch, struct regcache *regcache, > /* SVC - supervisor call */ > if (tdep->s390_syscall_record != NULL) > { > - if (tdep->s390_syscall_record (regcache, ibyte[1])) > - return -1; > + int res = tdep->s390_syscall_record (regcache, ibyte[1]); > + if (res != 0) > + return res; > } > else > { > > base-commit: 96cc0a530d58d96a81b1c30247de79812f1d4538 --------------dW0axZnxLibo0G7v7Zat5qTk Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit 
Hi Tom,
On 26/02/26 20:15, Tom de Vries wrote:
I ran into the same gdb.reverse/sigall-reverse.exp failure on ppc64le-linux,
as fixed in commits:
- commit 3686645cec9 ("[gdb/record] Fix return value for svc in
  aarch64_record_branch_except_sys"), and
- commit 4ef576bdb7f ("[gdb/record] Fix return value for syscall in
  loongarch_record_syscall_insn").

The difference with those commits is that the problem is not due to confusion
about a port-local enums (aarch64_record_result, loongarch_record_result).

Instead, the port just treats return values 1 and -1 the same:
...
	  if (tdep->ppc_syscall_record (regcache) != 0)
	    return -1;
...

Fix this by passing through the return value 1 instead.

Likewise on s390x-linux.

Tested on ppc64le-linux and s390x-linux.
---
 gdb/rs6000-tdep.c | 5 +++--
 gdb/s390-tdep.c   | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index 8aa155e1f36..7d0902941a0 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -7187,8 +7187,9 @@ ppc_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
 
       if (tdep->ppc_syscall_record != NULL)
 	{
-	  if (tdep->ppc_syscall_record (regcache) != 0)
-	    return -1;
+	  int res = tdep->ppc_syscall_record (regcache);
+	  if (res != 0)
+	    return res;
 	}
       else
 	{
I ran into the same issue on ppc64le and submitted a similar fix independently. 
I’ve tested your patch on Power10 (ppc64le), and it resolves the problem there as well.
Please feel free to add:
Reviewed-by: Abhay Kandpal <abhay@linux.ibm.com>
Thanks for addressing this and for covering s390x as well.
diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c
index 6cf5acbc542..f52e898047b 100644
--- a/gdb/s390-tdep.c
+++ b/gdb/s390-tdep.c
@@ -3242,8 +3242,9 @@ s390_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
       /* SVC - supervisor call */
       if (tdep->s390_syscall_record != NULL)
 	{
-	  if (tdep->s390_syscall_record (regcache, ibyte[1]))
-	    return -1;
+	  int res = tdep->s390_syscall_record (regcache, ibyte[1]);
+	  if (res != 0)
+	    return res;
 	}
       else
 	{

base-commit: 96cc0a530d58d96a81b1c30247de79812f1d4538
--------------dW0axZnxLibo0G7v7Zat5qTk--