From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58347 invoked by alias); 7 Apr 2017 10:48:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58237 invoked by uid 89); 7 Apr 2017 10:48:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Apr 2017 10:48:45 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EA4D2E6050; Fri, 7 Apr 2017 10:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8EA4D2E6050 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8EA4D2E6050 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EB85A60AA; Fri, 7 Apr 2017 10:48:44 +0000 (UTC) Subject: Re: [PATCH v2] Class-ify ptid_t To: Philipp Rudo , Simon Marchi References: <20170406190328.21103-1-simon.marchi@ericsson.com> <20170407112528.3f03fd37@ThinkPad> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5adec1b9-2faf-d8af-0116-c237ee591738@redhat.com> Date: Fri, 07 Apr 2017 10:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170407112528.3f03fd37@ThinkPad> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00165.txt.bz2 On 04/07/2017 10:25 AM, Philipp Rudo wrote: > In this context I ask myself what the error message is supposed to > say (unfortunately you are the first one in GDB actually using it, all > others only use an empty string). Is it what's expected ... > That's because the static assertion failure text includes both a file:line indicating where's the failure, and modern gcc/clang show you the line that failed, so it's not that big of a deal to not include a message: src/gdb/thread.c:1589:1: error: static assertion failed: static_assert (1 == 0, ""); ^ $ (and in C++17, static_assert got an overload with no second parameter, even.) > > static_assert (pid == ptid_t (1, 0, 0), "pid operator== returned false") > > > I tend more to what is expected. Definitely it should say what is expected, just like regular testsuite tests. Or say nothing when the expression is pretty clear already, which works for me too. :-) Thanks, Pedro Alves