From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oJqFM3HegWhRJDsAWB0awg (envelope-from ) for ; Thu, 24 Jul 2025 03:19:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=I3i6C0vS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=a9DenpJR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IieOu8ww; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0EY3+C2k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF9D31E102; Thu, 24 Jul 2025 03:19:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1258A1E091 for ; Thu, 24 Jul 2025 03:19:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 793883858CDA for ; Thu, 24 Jul 2025 07:19:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 793883858CDA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=I3i6C0vS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=a9DenpJR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IieOu8ww; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0EY3+C2k Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 1F5B83858D1E for ; Thu, 24 Jul 2025 07:18:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F5B83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F5B83858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753341516; cv=none; b=stfkohpvK+zNX35iackCy7gdPBIaT5xO4Szno0xAhiU/Khy2FyavSY/JgkJRBsM50eP4KXcAAFA9H+yZq8Ynji+l4oiZd1UBHB3GgIOZwCx1izKdVYH2KGWuill5l+1eCjAmBe5QdRpu9W8LZYquaGgi9GIUdt76ae3Dzm0dFYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753341516; c=relaxed/simple; bh=pyCHoYONe29C+a51EFORBFpkuSd5LzPt8iRWpY82umQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=mtr3kHeMNwVCOWGP5L5jX0U8hmzL6zlZtrLn9Uy0xLj7atVKEeOvLypqTx4+IBIek/uEgSr5sBsbO7Pe92Zwwv3EJq+2/X8ntKrOruz6dTVVYO7mH4GllnHzP5IB1IzFfXV11IR8Pp3DT7v9OjZwy25NDBqe5Vh042t94PcQZb8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F5B83858D1E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1CBDB1F394; Thu, 24 Jul 2025 07:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753341515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4CB4craiHSrwJJAcr2VR3fq00XJ64bc8kh2q+of2vY=; b=I3i6C0vSKn6VlgzCFfXwVuiHkugWr0OEW5iTYp2CGjVkmXiEDHcDnXidy3YjUVY0kw6u7+ BvbmNgggJzvI6YBEJ2JTzsZ88PfuYL5P7HnL04wBLWUAS9c05V6oWAS7MvafXqgu4qyNbu KJw41ibBKoS5EWxk0Gu9ti53/p9Kr88= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753341515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4CB4craiHSrwJJAcr2VR3fq00XJ64bc8kh2q+of2vY=; b=a9DenpJRPwWPj9xMv/Q9SC9vp4uX19C2fpUCLGZI4mokRH2oeS0LVyb9RWjJbezRkVgX17 MdFKruRT1Z3hRACQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IieOu8ww; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0EY3+C2k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753341514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4CB4craiHSrwJJAcr2VR3fq00XJ64bc8kh2q+of2vY=; b=IieOu8wwa7tUcEb6/TMz/Wk/hj4HEVfpQa5JI3NUXYQ3bwLM5g7o57qOlpSowfBnZ4MTXw oO/CjqvXLjXdcMJAyYz4fSH53pQsakdHir5/23TM3BD7vPRvqeAwNIBFlRTxiIlJHRduJf 5W0Ac5QyrTmeaC63OEEQyn2f5wx32V4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753341514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4CB4craiHSrwJJAcr2VR3fq00XJ64bc8kh2q+of2vY=; b=0EY3+C2kViWub0SFQ6LnFwzMJiX8cDvaREmalXQvPv13ZU/RMkZGD86u78HST14D2LPDzZ m2sZg28OUQovPqCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 05ED113302; Thu, 24 Jul 2025 07:18:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E4kUAEregWjQLAAAD6G6ig (envelope-from ); Thu, 24 Jul 2025 07:18:34 +0000 Message-ID: <5ac0f2ba-7b50-4f63-baf0-a7c5a567e6db@suse.de> Date: Thu, 24 Jul 2025 09:18:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] [gdb/testsuite] Log on return in Term::_log_cur To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250718130153.24989-1-tdevries@suse.de> <20250718130153.24989-4-tdevries@suse.de> <87h5z2u5hp.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87h5z2u5hp.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 1CBDB1F394 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/23/25 20:28, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> + set code [catch {uplevel $body} result] > > Tom> + if { $code == 1 } { > Tom> + global errorInfo errorCode > Tom> + return -code $code -errorinfo $errorInfo -errorcode $errorCode $result > Tom> + } else { > Tom> + return -code $code $result > Tom> + } > > I suspect this could be: > > catch {uplevel $body} result options > > and then just > > return -options $options $result Hi Tom, thanks for the review. You're right, if we can assume tcl 8.5 or later. It's not clear what the currently supported minimal version is, so I filed a PR about this ( https://sourceware.org/bugzilla/show_bug.cgi?id=33205 ), but probably it's 8.4 (with the exception of ada testing, which needs 8.5 since 2015, gdb 7.11). I've committed this as is. Thanks, - Tom