From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9D3FB385B835 for ; Sat, 18 Apr 2020 02:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9D3FB385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D25301E60C; Fri, 17 Apr 2020 22:30:45 -0400 (EDT) Subject: Re: [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test To: Mihails Strasuns , gdb-patches@sourceware.org References: <166773> <20200331171356.26126-1-mihails.strasuns@intel.com> From: Simon Marchi Message-ID: <5abb1182-cebd-34be-c782-02afa62097e6@simark.ca> Date: Fri, 17 Apr 2020 22:30:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200331171356.26126-1-mihails.strasuns@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2020 02:30:49 -0000 On 2020-03-31 1:13 p.m., Mihails Strasuns via Gdb-patches wrote: > Fixes jit-reader test failures on systems that have more registers than > expected by the current condition. > > On Intel i9-7920X the following extra registers are printed: > > k0 0x0 0 > k1 0x0 0 > k2 0x0 0 > k3 0x0 0 > k4 0x0 0 > k5 0x0 0 > k6 0x0 0 > k7 0x0 0 > > gdb/testsuite/ChangeLog: > > 2020-02-18 Mihails Strasuns > > * gdb.base/jit-reader.exp: relax register output check Please start with capital letter and end with a period. > Signed-off-by: Mihails Strasuns > Change-Id: I227ab8691b2363d626f7100216477ab637f619fa Update the commit title to mention jit, just saying "reader test" is vague. Might as well mention the test filename: allow more registers in gdb.bas/jit-reader.exp This patch is ok to push by itself with those fixed. Please remind me, do you have push access, or do you need/want it? If not I don't mind pushing for you. Simon