From: "Sébastien Darche" <sdarche@efficios.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] fix gdb.multi/checkpoint-multi.exp without symbols
Date: Wed, 8 Oct 2025 16:13:14 -0400 [thread overview]
Message-ID: <5ab99c30-645a-4976-b4d0-41400f9e6ef7@efficios.com> (raw)
In-Reply-To: <20251003170245.66b31978@f41-zbm-amd>
Thank you for your review. I just pushed the commit.
Sébastien
On 2025-10-03 20:02, Kevin Buettner wrote:
> On Tue, 30 Sep 2025 15:01:30 -0400
> Sébastien Darche <sdarche@efficios.com> wrote:
>
>> The checkpoint-multi.exp test stops a program while it is sleeping
>> using a call to the usleep() function from libc. The test checks whether
>> the inferior is running by matching for "<running>" (if the inferior
>> is running) or a hex address followed by a function name, ideally, if
>> the inferior is stopped.
>>
>> On most systems this works fine :
>>
>> (gdb) info checkpoints
>> Id Active Target Id Frame
>> * 1.0 y process 1546841 at 0x00007ffff7ceca7a, <clock_nanosleep>
>> 1.1 n process 1547177 at 0x00005555555551f0, file /home/sdarche/binutils-gdb/build-x86/gdb/testsuite/../../../gdb/testsuite/gdb.multi/hello.c, line 51
>> 2.0 y process 1547076 at 0x0000555555555243, file /home/sdarche/binutils-gdb/build-x86/gdb/testsuite/../../../gdb/testsuite/gdb.multi/goodbye.c, line 46
>> 2.1 n process 1547120 at 0x0000555555555285, file /home/sdarche/binutils-gdb/build-x86/gdb/testsuite/../../../gdb/testsuite/gdb.multi/goodbye.c, line 61
>>
>> I have found however that the output from `info checkpoints` is
>> different on some systems with (stripped) versions of the libc without
>> debug infos :
>>
>> (gdb) info checkpoints
>> Id Active Target Id Frame
>> * 1.0 y process 979642 at 0x00007ffff7e49687
>> 1.1 n process 979647 at 0x00005555555551ac, file /home/sdarche/binutils-gdb/build/gdb/testsuite/../../../gdb/testsuite/gdb.multi/hello.c, line 51
>> 2.0 y process 979645 at 0x000055555555523b, file /home/sdarche/binutils-gdb/build/gdb/testsuite/../../../gdb/testsuite/gdb.multi/goodbye.c, line 46
>> 2.1 n process 979646 at 0x0000555555555271, file /home/sdarche/binutils-gdb/build/gdb/testsuite/../../../gdb/testsuite/gdb.multi/goodbye.c, line 61
>>
>> Where the frame can be found, but GDB cannot find the function. This
>> fails the last two tests in checkpoint-multi.exp on those system, even
>> though the behaviour is as expected.
>>
>> This patch removes the comma from the regex that matches with the frame
>> number. The test now passes fine on the system.
> This is okay.
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
prev parent reply other threads:[~2025-10-08 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 19:01 Sébastien Darche
2025-10-04 0:02 ` Kevin Buettner
2025-10-08 20:13 ` Sébastien Darche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ab99c30-645a-4976-b4d0-41400f9e6ef7@efficios.com \
--to=sdarche@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox