From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YaINElE0eGo9WxYAWB0awg (envelope-from ) for ; Sun, 09 Aug 2026 04:03:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kEXlupn9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zDUN8Zz5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=o0E6XyKu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=m5UlKr+E; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 34EBB1E033; Sun, 09 Aug 2026 04:03:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A2D831E033 for ; Sun, 09 Aug 2026 04:03:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 676884BA79B5 for ; Sun, 9 Aug 2026 08:03:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 676884BA79B5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kEXlupn9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zDUN8Zz5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=o0E6XyKu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=m5UlKr+E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id EAD494BA540B for ; Sun, 9 Aug 2026 08:03:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAD494BA540B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAD494BA540B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786262583; cv=none; b=KulwjRFDz20fIy7P9xs0WsaU+TEPqWGn740OtlPp6h+cKdZul1Vsf6GPNOXLfoWGyQjdZeUeQYtd7c0i9FUz3sInoWXV9Iko7eZn197dIZUBpENtzQ8pG/B+Bh565EUID/cEWpdZHzZQHxk1WcyxnUNhe2jiWjZ+1GwGzz3N4KU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786262583; c=relaxed/simple; bh=8bLBTRMQ67Qqbm7CmmN8qbhEewKuniZyLAvo/Vpi/GE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=t93AeDNXFkGMhXfHgcvjlWvTE7Fs/ziW8hSCwOKZN3206NDf5sXO/a/bxn+Y0+gq8R7uEj/EeOLowRXoDUdmGcSD4FO5A+IfVtBzcr/QAEzLVvsT73195MqEQxL7S+EqYj8RbtNhouBVydAB1X5jR0c0syvxf9mY68f++sGMLBM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kEXlupn9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zDUN8Zz5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=o0E6XyKu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=m5UlKr+E DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EAD494BA540B Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A2A5F812AA; Sun, 9 Aug 2026 08:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786262577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNAZ3r+nJ/NIUOuNvoPQIZZgAnOPIdAEHe5GM5HuKm0=; b=kEXlupn9udeqPMAgzkMoOigPBtjQ2KIdnIXMOfeyYtYtP67nEBsoTU8IZ1NJjF0wffslfh agEJ4f7zaduQypQVPkFI2yP3DRM/AYsIC5wZCM/j8HY8PqiFiidIZOd5jqYgwn4obIj1CC snFypDeYTtLhNyB6d+8x/Xy7Ek8R1HU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786262577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNAZ3r+nJ/NIUOuNvoPQIZZgAnOPIdAEHe5GM5HuKm0=; b=zDUN8Zz5OA2AqXMOKt9/tKuC0AuxrnyrHC/BynLxkGv8x7mNBdWuHfYUK0rnRaFGHeqTLF DoiZXtMMOnISqbBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786262573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNAZ3r+nJ/NIUOuNvoPQIZZgAnOPIdAEHe5GM5HuKm0=; b=o0E6XyKu4akNWRmd3sKszmXk8Ux5ulHYNGd9hVLDAUYAYIEnRTNI6tgbWVHzFftcukdq4o ntwvqbUinbULY7AAWFG2/F4m+7tSW++dk//iW5BZVg5rR0y4jfqtndKeCFM/NhzDikZupl DEeybLv+IUhhBeuehaUGBg05lSWEC3U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786262573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNAZ3r+nJ/NIUOuNvoPQIZZgAnOPIdAEHe5GM5HuKm0=; b=m5UlKr+EBcptpOb0ZD8Wpd/H5NOTbmeD96aHzvyVnS6vhtxTRraXUSr1f204vJvG4Z2FB0 11z2jpS9BTw2hyBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 87FEA779B2; Sun, 9 Aug 2026 08:02:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tXynHy00eGoBXAAAD6G6ig (envelope-from ); Sun, 09 Aug 2026 08:02:53 +0000 Message-ID: <5aacbfe8-7e65-4164-a3da-49b406e1786e@suse.de> Date: Sun, 9 Aug 2026 10:02:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] Python safety initial work To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260521-python-safety-initial-v3-0-d0679c36e499@tromey.com> <87qzmbdb6p.fsf@tromey.com> <87fr1e99yh.fsf@tromey.com> <464776ce-eadc-4ad9-8757-87e4457c7ce9@suse.de> <87ldahyano.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87ldahyano.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/7/26 9:48 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> I found this code: > Tom> ... > Tom> /* Note this returns a borrowed reference. */ > Tom> PyObject *arg = PyTuple_GetItem (args, i); > Tom> ... > Tom> and decided to try to convert all PyTuple_GetItem calls. The result > Tom> of that exercise is attached. > > Tom> I ended up also touching the wrapper function: > Tom> ... > Tom> static inline gdbpy_borrowed_ref<> > Tom> gdbpy_tuple_get_item (gdbpy_borrowed_ref<> tuple, Py_ssize_t pos) > Tom> { > Tom> - PyObject *result = PyTuple_GetItem (tuple, pos); > Tom> + gdbpy_opt_borrowed_ref<> result = PyTuple_GetItem (tuple, pos); > Tom> if (result == nullptr) > Tom> throw gdb_python_exception (); > Tom> - return result; > Tom> + return (PyObject *)result; > Tom> } > Tom> ... > Tom> but perhaps you left that out intentionally? > > Yeah, in this spot it didn't seem to really be necessary. > The idea of the wrapper file is to eventually isolate all "raw" calls to > the Python API. > > Tom> I haven't used the gdbpy_tuple_get_item wrapper, AFAICT it was not > Tom> applicable. > > The long term goal is to convert everything to call the wrappers. > This way exception handling will be enforced. Ok, I've started over and converted valpy_call, now indeed using gdbpy_tuple_get_item. Thanks, - Tom