From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20144 invoked by alias); 16 Jan 2020 02:57:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20133 invoked by uid 89); 16 Jan 2020 02:57:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1892 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 02:57:33 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1B5C61E4B2; Wed, 15 Jan 2020 21:57:32 -0500 (EST) Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Tom Tromey , gdb-patches@sourceware.org References: <20200109005807.7314-1-tom@tromey.com> From: Simon Marchi Message-ID: <5a9d5f71-aecd-8151-c8cd-174affb3aaf3@simark.ca> Date: Thu, 16 Jan 2020 04:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200109005807.7314-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00443.txt.bz2 On 2020-01-08 7:58 p.m., Tom Tromey wrote: > Here is an update of the series to move gdbsupport to the top level. > This is one step in the bigger projecct to move gdbserver to top > level. > > In this patch, gdbsupport is given its own configure script -- > however, gdbserver still builds its own copy. gdb and gdbserver won't > share a gdbsupport library until the final series. > > This version of the patch fixes up the problems that Pedro pointed out > in the shared nat/ and target/ code. In particular, now they can > simply rely on the shared config.h. This is enforced by ensuring that > the necessary defines are all available; the checker script I used to > find the issues is provided in patch #5. > > I wasn't able to send this through the buildbot. I did test it on > x86-64 Fedora 29. I also build it using a mingw cross. > > If you want to try it, it is on the branch > submit/move-gdbsupport-to-top in my github. > > Let me know what you think. > > Tom Hi Tom, I think we are missing a dependency of the gdbsupport directory on the bfd directory. In a build from scratch, try to do "make all-gdbsupport". You should get: make[2]: Entering directory '/home/simark/build/binutils-gdb/gdbsupport' CC agent.o In file included from /home/simark/src/binutils-gdb/gdbsupport/common-defs.h:109, from /home/simark/src/binutils-gdb/gdbsupport/agent.c:20: /home/simark/src/binutils-gdb/gdbsupport/common-types.h:35:10: fatal error: bfd.h: No such file or directory 35 | #include "bfd.h" | ^~~~~~~ Note that on my development machine, I didn't see this problem at first, but then I realized that it was including /usr/include/bfd.h. After I deleted it, I got the error. In the top-level Makefile, gdbsupport currently depends on configure-bfd. I suppose it should depend on all-bfd, since it needs for bfd.h to be generated? Simon