From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IkDCBLwMGWBdJAAAWB0awg (envelope-from ) for ; Tue, 02 Feb 2021 03:26:36 -0500 Received: by simark.ca (Postfix, from userid 112) id 04A811EF80; Tue, 2 Feb 2021 03:26:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5B34A1E939 for ; Tue, 2 Feb 2021 03:26:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C03C5396EC18; Tue, 2 Feb 2021 08:26:34 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 175B03857015 for ; Tue, 2 Feb 2021 08:26:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 175B03857015 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3471BAD4E; Tue, 2 Feb 2021 08:26:31 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Fix gdb.dwarf2/fission-reread.exp with .gdb_index To: Simon Marchi , gdb-patches@sourceware.org References: <20210201144335.GA1920@delia> <07304c7c-e670-d2fe-19e1-e56ece7271b5@polymtl.ca> From: Tom de Vries Message-ID: <5a5925fa-f18b-3d70-253e-96c1774e9652@suse.de> Date: Tue, 2 Feb 2021 09:26:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <07304c7c-e670-d2fe-19e1-e56ece7271b5@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2/1/21 5:24 PM, Simon Marchi wrote: > I got these when applying the patch: > > Applying: Fix gdb.dwarf2/fission-reread.exp with .gdb_index > .git/rebase-apply/patch:24: trailing whitespace. > > .git/rebase-apply/patch:179: trailing whitespace. > > .git/rebase-apply/patch:229: trailing whitespace. > #define XSTR(s) STR(s) > warning: 3 lines add whitespace errors. > > Can you hunt them down? > Ack, done. [ And I've added this check to my git-format-patch.sh command. I was under the impression that I got all the whitespace by looking at the git diff output, but evidently not. ] > Otherwise, LGTM. Thanks, committed. - Tom