From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-140394-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28500 invoked by alias); 14 Jul 2017 15:16:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 28404 invoked by uid 89); 14 Jul 2017 15:16:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 15:16:25 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 2F4013A8338;	Fri, 14 Jul 2017 15:16:24 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F4013A8338
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2F4013A8338
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 8C4BE6FE50;	Fri, 14 Jul 2017 15:16:23 +0000 (UTC)
Subject: Re: [RFA 2/2] Remove BITS_IN_BYTES define
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-3-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <5a4a5c82-c956-34a6-ede9-f30ca9879848@redhat.com>
Date: Fri, 14 Jul 2017 15:16:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170713123400.28917-3-tom@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-07/txt/msg00186.txt.bz2

On 07/13/2017 01:34 PM, Tom Tromey wrote:
> @@ -432,8 +432,8 @@ print_scalar_formatted (const gdb_byte *valaddr, struct type *type,
>      case 'd':
>      case 'u':
>        {
> -	bool is_signed = options->format != 'u' || !TYPE_UNSIGNED (type);
> -	print_decimal_chars (stream, valaddr, len, is_signed, byte_order);
> +	bool is_unsigned = options->format == 'u' || TYPE_UNSIGNED (type);
> +	print_decimal_chars (stream, valaddr, len, !is_unsigned, byte_order);
>        }
>        break;
>      case 0:

Ah, looks like you meant to squash this hunk in the previous patch...

The actual BITS_IN_BYTES bits are fine.

Thanks,
Pedro Alves