From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91274 invoked by alias); 13 Dec 2017 15:58:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91264 invoked by uid 89); 13 Dec 2017 15:58:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 15:58:00 +0000 Received: from ESESSHC009.ericsson.se (Unknown_Domain [153.88.183.45]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 2A.48.00652.50E413A5; Wed, 13 Dec 2017 16:57:57 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.45) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 13 Dec 2017 16:57:56 +0100 Received: from [100.94.228.6] (129.192.64.65) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.4; Wed, 13 Dec 2017 15:57:54 +0000 Subject: Re: [PATCH 0/3] Fix regression: expression completer and scope operator (PR gdb/22584) To: Pedro Alves , References: <1513171596-10665-1-git-send-email-palves@redhat.com> From: Simon Marchi Message-ID: <5a439ff4-6f7e-235a-6ce2-2d70eae2387c@ericsson.com> Date: Wed, 13 Dec 2017 15:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513171596-10665-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR06CA0083.namprd06.prod.outlook.com (2603:10b6:4:3a::24) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9256d28-9239-4ece-4b4c-08d542424641 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307);SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;3:+g2CRpvWCajho4C5ot5Lhwd+2NsNOyR5R8OEaKYXHf7CpClyYd+HdyzAIv54EFc651OKFvPRmeNgbzMGeTgJTBOoJizkmu5CERnwPNaezOZwo0meQ5j6pkuq9N7ePI3ELO8i9BoTQU9inbZ3VWYYQwu9W/bjJ105efm9LvidXhwQy8pTInNILm5blU8PP1lGQGbX/GjJKZgyin95vP5AwClkYGivH2C9Sc/cAz5c/i76C7oU2bcbPcaXC97QPmTf;25:Mu1tai0DFBkcO8CRlDaG7mjq4HM5aTc/zO8jlX6+1kwByie73G3tDEINSoWTdbdALdWk7rTLn443PQQY36xHDFf9jCynQBuG7zTMWhFtJGU6CqWtx2BsyklnRId+sxAAy8+b+EgSrwLPQ8fAtDM742voEo5CrF2nyCuaaHkNNcYEwx+Xxm9O3IDa8jPcbQ1dsbPpiUlTekXvbEM339NuxhrKaFo1H2Das7xf7wBvuRFiZ2b51n6y52VX/a4r6cdqmNQ58+RrGYujNbzNOsvTUqLGC5IiOS5Mi7mb4vQvVfATHeyMEFScQksCwXILvSbXMnqdx/xfrvvbB/PxVjgQuCCSjrE6hq7lxJutmdgi5BQ=;31:JQT3vukRZYFFyylthhHdzThDrr+XfAPa9YLNAr097dcTMIqGyOrxosrxNStpfTJYoTso102nZT4tF/XXKn0rGj7nDd6VBEEFmNC7JkV+y4Ui8AHQ9z02uI3rokqlPxxArg5xbVd03bj45Tj458Y33ioPB/rBXdDpgyoPMF/Kaey2GLJOyFl6xxrqkVfDzLpC5Q8R6y00WhRDsUH+0/sKEn/aD3+hhpevYybO8Aelp/o= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;20:2U1P1+8xJuI6H3ZcQMcKBWFWFKEL8TbObardztqdJ+0ZqgLt7xUupjP0wTMVZRx5thnorkEX2U0vBckTZ4IBjgCRNQ1mTChvLwgRWggl2Nl5+ZJdubYMVk7yImzH2OYzJj9CQJoC9ltc/uW8n/V0set5drugsFCFcwDKRhoqG0q5sMwwBrBP2FUR61R+QvBNvLud+JxoCpqqOrT+Szhlgb7FRblDugYNd5LdWzZDIcO0DSxgOVFxu34dUjFqERjLurwWSjjqB4kMZUry3oSOErECa3IIMnJpEPV/5khWW2Pbap9e/J2YdNyQGdfmyB6qm5t6i4ziZ4AkYQHClQahy4aWPEFd8yzx1toLfHLYwYGTycYjZ1xVhydteN1czmP0U2BIdNQVsfhl7BN6XVKY5QvOw+KWGMqQBTs2yN58TNE1vpzMJDtRSKfArZkdzTIPKHMtthxJi3H/58mjojt3uOIZ4yhgW0mfvmjSKT8OV14oy64/Lzlj8sv4heZ3wtyO;4:riYaS1VQWNBV+MSDdokXtcdBYIcqRnWjgbojhJ8EhKPI+5HiT012a1/Qx9z1EurbcXW+lzdSqN8CcEInF879daHEvKS106IfEqv0Ca1sEzT+c3ddUv8VK9zsoOCQ8llf1VL1Si/xLQtDhEH4UNM5Jjebde2V27pnwDWo53iKZD8PeXZ9yBf5FmP0qRbLn2xfEY+95CcE4QRYu1HvUhsBOL7hYBqo9GJQ03ZPK+CSqvJ8ddQqqGYU4UFsaRKUsoCgKT/r577BysYgmZf88B27Ug== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(10201501046)(3002001)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011);SRVR:AMSPR07MB310;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AMSPR07MB310; X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(376002)(366004)(346002)(377424004)(199004)(189003)(24454002)(50466002)(64126003)(230700001)(478600001)(105586002)(25786009)(23676004)(2906002)(52146003)(106356001)(16526018)(53546011)(2486003)(4001150100001)(229853002)(386003)(2950100002)(83506002)(52116002)(5660300001)(6486002)(76176011)(6666003)(68736007)(65826007)(49976008)(97736004)(316002)(16576012)(81166006)(81156014)(31686004)(8676002)(6246003)(31696002)(305945005)(53936002)(65956001)(47776003)(7736002)(66066001)(65806001)(8936002)(6116002)(36756003)(3846002)(86362001)(58126008)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB310;H:[100.94.228.6];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTA7MjM6aTdPUk1EQjZBVzdjY3RpM0dPN3FVRjUyTEE2?= =?utf-8?B?MmI5VEZNY3ZieDBLeGgvRmVncG5jRzFBT3Y1MTBpYjA0WWRQRk15U0Z3TDJr?= =?utf-8?B?N245Ujd0dWlLR21yWnYwcjkzV0tVZjd5YmFSa1JjaEdVdHU0OHUreEQzNFM5?= =?utf-8?B?clZUWDlGcUY2MkNuS0JiM2tGbTJnM09EaDU4V0s0Nmwyd211VVplYTMxeDUw?= =?utf-8?B?YWlvZjg2Wmh6cXZlaGgrc1NnajB4dXpqeFN6RW94U2lHdWF3b290TWtVUEd5?= =?utf-8?B?MnIyNkwwVVBINGJmSmNSb3p6Z3RtMDdBNlFTcW9SV04xTXcrcmZXTkFXMDU5?= =?utf-8?B?dmc5SFgvZTBHTXFJeFdhM3ZmOGgxdEx0Qm9Ybll0Q1F1UmNrT1RFaENaeVFn?= =?utf-8?B?WS9pMnJnd3dGNHJFVTdrcEpDTFcyblk0anloWGhkMUFXbHp6TUZZNGZMWDRv?= =?utf-8?B?QUoyak5nRWY0VGJpa1J4RHR5Tk9xRENzYmVaMTluTm94Mm1sbDRNVGR1SWdM?= =?utf-8?B?YnpwREZKd21RSDd0T1F4S1loczJ2VEZ0Q1ZMYi8rWnFZeVpQK3BKMzhNY1Mr?= =?utf-8?B?UUV2YjhscVBBRjlNajJlYWJQZDFLZ1BNVE80eVBNMHBRd2Q2N25PRE9ranpv?= =?utf-8?B?eXhqaGFDZWRqelRWY3NGNmtMblN1V0xQU05GV2ZqV0RSc1pHMko4eGkvNWdt?= =?utf-8?B?WURyQUZzOEtVcU9ieWIxYUNkcXpNcHhLa20zc2h6dkxONmJUM0F3N0ZIT3pX?= =?utf-8?B?KzJzcmlpd0F1SW5LL2VrOEtmZHJOaS8rVDZyLzZHeTFHSmJwUEJhcUZoNWV6?= =?utf-8?B?ZmVaV1pwNVovWTBhbUF6cGQ3THM5eHcxclphZHVseTNQdjBzNUJtK01lbGYx?= =?utf-8?B?UzBtS1NWaXUvSWxQWmVULzhVUGxVdU1jQ3N6NWtETUM3WEN1VGljN0tHaWRU?= =?utf-8?B?OEhRdHJwTG9vVXhiV28yR3Z4NjByeEEvdVJvUEZ4b0p6eGI0THMrKzc1ZkJu?= =?utf-8?B?ZTBMSjRabU9tTm5laEpNNmgwczBiOXJsekl3RW9yZWVTQkl1SkRxdytaa1Na?= =?utf-8?B?S1FnR1Z4RWtjQXN2L0g4ajhYWDE1SWpjZEt5ZlBMZzNlMzJsVFhZNkphYmJ2?= =?utf-8?B?a1NBVkg5KzQvWnpZanRvcnFnTnFFQkI4NkZ2QU5OVjloazR0MXQ5eWQrV2ZQ?= =?utf-8?B?TG9QQ2RiUm1jSXNmWXc5dXFrOGFmR3RPcktmNGhEVmY0bmdxN0l6VllJa2I3?= =?utf-8?B?Vmp6TDc2WGxPU1lhSUFydzJBMUxPcFhJcWNWcGdoeTZyTEwzakRtNWM1K1ZG?= =?utf-8?B?Ujh1eldxWjRXYlZXR013QUtJUkdmSEFYc3M4RjgzUUIxcEhkQWNkNEh6aTUy?= =?utf-8?B?YURuTUxjcFd2Zk1MQUtSWVo3NHo0T0lrWkN6VW9FNWI2NmJja2hzODNjWDYv?= =?utf-8?B?YURaSC9MZHA3MWM1czREM1FvNlNmd29LK21CVnpzQmQvVFAwYzRtVURqbjZ3?= =?utf-8?B?d3pKZUZXY1ptNmZhRUR2WXA2T1pnL3VvWkt6MXh6NC90SThYY2ZJclZMNndT?= =?utf-8?B?SGUzLzBuOVRNY3RMNmdibnVaTXlBN2RVdTdDL2drVEtobmNWSjRpOGljNURw?= =?utf-8?B?Zy9jVHRoZU5tQ2hQTUQ1YUdEZ3kxdG14SXdVNitSTHdTNDh5YWVkUkpwdDYr?= =?utf-8?B?c2NrOFRGeXRNdjkvVXVEYWFlZGdING41ZHZYeUsvRHlmdER6VFR4L2p5Znh1?= =?utf-8?B?ZTRFMTlIcHBsVWhzNG1UbURjckpxd0dCMzFoYnkyQjZ1STJrOS9wUGZITFh2?= =?utf-8?B?OWt2SldSWURpTGRsd095bktBQWxGWGFtbXVTS2RZem41dz09?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;6:+UyFAPLlxSFdXxaq/PzJ/9b06TzIy4+h3hjsoD3UT41LgOyMLRG3o4dAwNqOC7XNeG81G5W5OyPfk/5m/C306uyWwMFUX2kihFR2RKqKJilq0kjBd7eSoFSUsTHYca4WGRaegDr0v7sPT9VgGVm37mfo7x7yo67uKt3tyBDtP6TOXEojZDdqtVAgzoojVOhxHMlrfOYzbRRSLhJhGo9lBdSxVVh1tuj46RxF/XTlDQAZH7c4oHpNVKF36VJeR8WDtjU+lLNi1UDIvHsDuz0bRnL5cIHfQty6EyfMd2MQ4BgjPcqNcGcnh+nl64tNLUA3tEyQEDQKN2OP8RBV3prnCXzLDFIV0Cg3LUG9SEvqyiE=;5:MJWnfKfc7ojv3GlNQb89t6CTsUcER9w31RZ9XqVMlFEjtujrFyKswo/AgPw9l6fRPvbSh2vaMLw7BGmexBRewE6pCQBGUyQjphHWHxnKCCHLTbG0rPRhWQgJ+hTCv+e77FCqPlJDTpmkyKgziujbUFTp+UFi5DnIhYNnfsXPAL0=;24:uuHesKgIBEIQurWhELVsD8jdBNP2+Q37QQYGiF87ODXofBKlbnfrjFqQRu18lV6LNrs/0tXHxvvT02jkDav3+k28KbScyFZSi7U1wwtspNs=;7:RLyrNcDorNXDfQzSS+bk5bQ1K+A12P09vgzVXRgZEmuU9hOFn8VCSJhzwLdOFPiKTl11xK4UtMv/1Jgh9dQPTZT/vBQji5c1ke1lZ8MCvXwhw4LE7ebAQzndy5dA23TIkZj1fVnK8oIVryT/RCEL3JzhphOoBRGPPW613AQpBEY6+xrTsjr2ocX8Ua4Au9t0fotqlRUDxP6pvYuyd8g09pISdpszRAVrP+SJoHuQ1pzH6v4wP6EMlFsdVOi1lfvA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 15:57:54.8158 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9256d28-9239-4ece-4b4c-08d542424641 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00308.txt.bz2 On 2017-12-13 08:26 AM, Pedro Alves wrote: > This patch series fixes PR gdb/22584, a regression in the expression > completer: > > "(gdb) p std::[TAB]" => "(gdb) p std::std::" > > GDB got confused above, there's no such thing as "std::std::". > > Patch #1 factors out some code duplicated throughout the codebase. > > The new function patched by patch #1 is used by patch #2 (the actual fix) uses. > > Patch #3 fixes something in the new completion testing support > routines that I noticed while writing the tests for patch #2. > > Pedro Alves (3): > Factor out final completion match string building > Fix regression: expression completer and scope operator (PR gdb/22584) > Tighten regexp of > lib/completion-support.exp:test_gdb_complete_tab_multiple > > gdb/cli/cli-decode.c | 41 +---------- > gdb/completer.c | 115 +++++++++++++++++++++---------- > gdb/completer.h | 24 ++++++- > gdb/interps.c | 20 +----- > gdb/symtab.c | 52 ++------------ > gdb/testsuite/gdb.cp/cpcompletion.exp | 42 +++++++++++ > gdb/testsuite/gdb.cp/pr9594.cc | 13 ++++ > gdb/testsuite/lib/completion-support.exp | 7 +- > 8 files changed, 169 insertions(+), 145 deletions(-) That series looks good to me. Simon